Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SoftMax Pro - report non numeric values in error document #713

Merged
merged 9 commits into from
Oct 11, 2024
Merged

feat: SoftMax Pro - report non numeric values in error document #713

merged 9 commits into from
Oct 11, 2024

Conversation

slopez-b
Copy link
Collaborator

@slopez-b slopez-b commented Oct 9, 2024 •
edited
Loading

Use error documents to report non numeric values found in measurements and calculated data.

@slopez-b slopez-b changed the title Slopez/smp report non numeric values in error document feat: SoftMax Pro - report non numeric values in error document Oct 11, 2024
@slopez-b slopez-b marked this pull request as ready for review October 11, 2024 00:58
james-leinas
james-leinas previously approved these changes Oct 11, 2024
View reviewed changes
nathan-stender
nathan-stender requested changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@nathan-stender nathan-stender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM - one tiny nit on a comment

src/allotropy/parsers/moldev_softmax_pro/softmax_pro_structure.py Outdated Show resolved Hide resolved
@slopez-b slopez-b merged commit 477d29e into main Oct 11, 2024
5 checks passed
@slopez-b slopez-b deleted the slopez/smp-report-non-numeric-values-in-error-document branch October 11, 2024 22:15
@alejandro-salgado alejandro-salgado mentioned this pull request Oct 15, 2024
Merged
alejandro-salgado added a commit that referenced this pull request Oct 15, 2024
@alejandro-salgado
release: Update allotropy version to 0.1.60 (#723)
7e9dfe2 
## [0.1.60] - 2024-10-15

### Added

- Add electrophoresis/BENCHLING/2024/09 schema and mapper and update
Aglient Tapestation parser to use it. (#715)
- Add solution-analyzer/rec/2024/09 schema mapper (#714)
- SoftMax Pro - report non numeric values in error document (#713)
alejandro-salgado added a commit that referenced this pull request Oct 16, 2024
@alejandro-salgado
Revert "feat: SoftMax Pro - report non numeric values in error docume…
81e24b8 
…nt (#713)"

This reverts commit 477d29e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathan-stender nathan-stender nathan-stender approved these changes

@james-leinas james-leinas james-leinas left review comments

@alejandro-salgado alejandro-salgado Awaiting requested review from alejandro-salgado alejandro-salgado is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slopez-b @nathan-stender @james-leinas