Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add electrophoresis/BENCHLING/2024/09 schema and mapper and update Aglient Tapestation parser to use it. #715

Merged
merged 21 commits into from
Oct 15, 2024
Merged

feat: Add electrophoresis/BENCHLING/2024/09 schema and mapper and update Aglient Tapestation parser to use it. #715

merged 21 commits into from
Oct 15, 2024

Conversation

alejandro-salgado
Copy link
Collaborator

  • Move electrophoresis rec 09/24 as benchling 09/24 schema
  • Implement schema mapper for electrophoresis benchling 09/24
  • Update Agilent Tapestation Analysis parser to use electrophoresis benchling 09/24 schema

james-leinas
james-leinas previously approved these changes Oct 11, 2024
View reviewed changes
nathan-stender
nathan-stender requested changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@nathan-stender nathan-stender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, just changelog undo

CHANGELOG.md Outdated Show resolved Hide resolved
src/allotropy/allotrope/schemas/adm/electrophoresis/BENCHLING/2024/09/CHANGE_NOTES.md Show resolved Hide resolved
@nathan-stender
Copy link
Collaborator

nathan-stender commented Oct 11, 2024 •
edited
Loading

Can you change title to:

feat: Add electrophoresis/BENCHLING/2024/09 schema and mapper and update Aglient Tapestation parser to use it.

@alejandro-salgado alejandro-salgado changed the title feat: add benchling schema and mapper for electrophoresis 09/24 and update tapestation to use it feat: Add electrophoresis/BENCHLING/2024/09 schema and mapper and update Aglient Tapestation parser to use it. Oct 15, 2024
@alejandro-salgado
Copy link
Collaborator Author

James ask me to add the processed data aggregate document to DeviceControlAggregateDocument instead of just removing the previous processed data document

james-leinas
james-leinas approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@james-leinas james-leinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@alejandro-salgado alejandro-salgado merged commit 17481d1 into main Oct 15, 2024
5 checks passed
@alejandro-salgado alejandro-salgado deleted the tapestation-0924 branch October 15, 2024 19:57
@alejandro-salgado alejandro-salgado mentioned this pull request Oct 15, 2024
Merged
alejandro-salgado added a commit that referenced this pull request Oct 15, 2024
@alejandro-salgado
release: Update allotropy version to 0.1.60 (#723)
7e9dfe2 
## [0.1.60] - 2024-10-15

### Added

- Add electrophoresis/BENCHLING/2024/09 schema and mapper and update
Aglient Tapestation parser to use it. (#715)
- Add solution-analyzer/rec/2024/09 schema mapper (#714)
- SoftMax Pro - report non numeric values in error document (#713)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathan-stender nathan-stender nathan-stender approved these changes

@james-leinas james-leinas james-leinas approved these changes

@slopez-b slopez-b Awaiting requested review from slopez-b slopez-b is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alejandro-salgado @nathan-stender @james-leinas