Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: AppBio Quantstudio - remove omitted wells from calculated data document data sources #717

Merged
merged 2 commits into from
Oct 11, 2024
Merged

fix: AppBio Quantstudio - remove omitted wells from calculated data document data sources #717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba60a3d
Remove omitted well items from data sources of calc docs
nathan-stender Oct 11, 2024
9d5fda0
Simplify
nathan-stender Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions src/allotropy/parsers/appbio_quantstudio/appbio_quantstudio_calculated_documents.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,9 +605,6 @@ def iter_comparative_ct_calc_docs(
calc_docs: list[CalculatedDocument | None] = []
for sample, target in view_st_data.iter_keys():
for well_item in view_st_data.get_leaf_item(sample, target):
if not well_item.has_result:
continue

calc_docs.append(build_quantity(view_tr_data, target, well_item))
calc_docs.append(build_amp_score(well_item))
calc_docs.append(build_cq_conf(well_item))
Expand Down Expand Up @@ -639,9 +636,6 @@ def iter_standard_curve_calc_docs(
calc_docs: list[CalculatedDocument | None] = []
for sample, target in view_st_data.iter_keys():
for well_item in view_st_data.get_leaf_item(sample, target):
if not well_item.has_result:
continue

calc_docs.append(build_quantity(view_tr_data, target, well_item))
calc_docs.append(build_amp_score(well_item))
calc_docs.append(build_cq_conf(well_item))
Expand Down Expand Up @@ -672,9 +666,6 @@ def iter_relative_standard_curve_calc_docs(
calc_docs: list[CalculatedDocument | None] = []
for sample, target in view_st_data.iter_keys():
for well_item in view_st_data.get_leaf_item(sample, target):
if not well_item.has_result:
continue

calc_docs.append(build_quantity(view_tr_data, target, well_item))
calc_docs.append(build_amp_score(well_item))
calc_docs.append(build_cq_conf(well_item))
Expand Down Expand Up @@ -708,9 +699,6 @@ def iter_presence_absence_calc_docs(
calc_docs: list[CalculatedDocument | None] = []
for sample, target in view_data.iter_keys():
for well_item in view_data.get_leaf_item(sample, target):
if not well_item.has_result:
continue

calc_docs.append(build_quantity(None, target, well_item))
calc_docs.append(build_amp_score(well_item))
calc_docs.append(build_cq_conf(well_item))
Expand All @@ -727,6 +715,7 @@ def iter_calculated_data_documents(
r_sample: str | None,
r_target: str | None,
) -> Iterator[CalculatedDocument]:
well_items = [well_item for well_item in well_items if well_item.has_result]
view_st = SampleView(sub_view=TargetView())
view_st_data = view_st.apply(well_items)

Expand Down
Loading
Loading