fix: Fix error for NanoDrop Eight Adapter where the column names are different than the expected. #728
+306
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
joshua-benchling
commented
Oct 18, 2024
joshua-benchling
commented
- Standardize the column names used in the NanoDrop eight adapter
joshua-benchling
requested review from
slopez-b,
alejandro-salgado and
a team
as code owners
nathan-stender
requested changes
Oct 19, 2024
| @@ -7,13 +7,22 @@ | |||
| from allotropy.parsers.lines_reader import CsvReader | |||
| from allotropy.parsers.utils.pandas import read_csv | |||
|
|
|||
| COLUMNS_MAP = { | |||
| "Sample Name": ["Sample"], | |||
There was a problem hiding this comment.
The preferred approach for this is to add options to the SeriesData getter, e.g:
data.get(str, "Sample") -> data.get(str, ["Sample", "Sample Name"])
This would address date/sample, but I noticed we only use "Sample" to detect the start of the table.
I went ahead and refactored the reader a bit to make it more robust, and addressed this fix while I was at it, here: #731
So, you can go ahead and close this PR out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.