Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some corrections #2

Open
wants to merge 3 commits into
base: private/bengangy/CP-44371
Choose a base branch
from
Open

Some corrections #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44fbed6
Some layout and wording tweaks.
kc284 Sep 27, 2023
c281bef
Moved NRPE related files to the same folder.
kc284 Sep 27, 2023
9fff620
Some corrections in wording, code style, C# usage, and null checks.
kc284 Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion XenAdmin/Dialogs/PropertiesDialog.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ private void Build()
}
if (isHost || isPool)
{
NRPEEditPage = new NRPEEditPage(isHost);
NRPEEditPage = new NRPEEditPage();
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking this is not wrong, but because we have a dedicated method that sets the IXenObject on the panel, it is more tidy if this is examined within that method.

ShowTab(NRPEEditPage);
}
}
Expand Down
136 changes: 48 additions & 88 deletions XenAdmin/SettingsPanels/NRPEEditPage.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading