Update 06.know-your-problem.md #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benjamin-Lee
requested changes
Oct 12, 2020
Co-authored-by: Benjamin Lee <[email protected]>
Co-authored-by: Benjamin Lee <[email protected]>
Closed
Benjamin-Lee
approved these changes
Oct 15, 2020
chevrm
approved these changes
Oct 16, 2020
|
Hey - I’ve been trying to read all of the threads and everything sounds good. I’m planning to go through all again now - is it best to “pull” the newest version into my fork?
… On Oct 16, 2020, at 1:09 AM, Benjamin Lee ***@***.***> wrote:
Merged #258 <#258> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#258 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALZJEZUOI6LSCADVLSL5CFTSK7IQTANCNFSM4SLS3BZA>.
|
|
Yes, I suggest you pull the newest version in. You should right now, no one is working on significant revisions so there won't be any merge conflicts to parse out. @rasbt mentioned in #226 that he's planning on doing one last round of revisions on Monday, so it would be ideal if you could work on any PRs before then so we don't have them going on in parallel. Thanks! |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 16, 2020
[ci skip] This build is based on 881a98c. This commit was created by the following CI build and job: https://github.com/Benjamin-Lee/deep-rules/commit/881a98c3d37cd00c0a52f00f89576889db90b203/checks https://github.com/Benjamin-Lee/deep-rules/runs/309999788
github-actions bot
pushed a commit
that referenced
this pull request
Oct 16, 2020
[ci skip] This build is based on 881a98c. This commit was created by the following CI build and job: https://github.com/Benjamin-Lee/deep-rules/commit/881a98c3d37cd00c0a52f00f89576889db90b203/checks https://github.com/Benjamin-Lee/deep-rules/runs/309999788
|
Sounds great, just pulled in everything, no merge issues, and will send all PRs by Sunday night (one per document again). Thanks again!
Michael
… On Oct 16, 2020, at 5:31 PM, Benjamin Lee ***@***.***> wrote:
Yes, I suggest you pull the newest version in. You should right now, no one is working on significant revisions so there won't be any merge conflicts to parse out. @rasbt <https://github.com/rasbt> mentioned in #226 <#226> that he's planning on doing one last round of revisions on Monday, so it would be ideal if you could work on any PRs before then so we don't have them going on in parallel. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#258 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALZJEZS2VKK7PCLBC4U5GODSLC3UFANCNFSM4SLS3BZA>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you add yourself as a contributor if this is your first contribution?
Any more details?