fix operator+ being picked for 3rd party types (nholthaus#299)

BenjaminNavarro · Nov 18, 2022 · e586885 · e586885
1 parent 3ca0e22
commit e586885
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/include/units.h b/include/units.h
@@ -2503,7 +2503,7 @@ namespace units
 	//	LINEAR ARITHMETIC
 	//------------------------------
 
-	template<class UnitTypeLhs, class UnitTypeRhs, std::enable_if_t<!traits::is_same_scale<UnitTypeLhs, UnitTypeRhs>::value, int> = 0>
+	template<class UnitTypeLhs, class UnitTypeRhs, std::enable_if_t<traits::is_unit_t<UnitTypeLhs>::value && traits::is_unit_t<UnitTypeRhs>::value && !traits::is_same_scale<UnitTypeLhs, UnitTypeRhs>::value, int> = 0>
 	constexpr inline int operator+(const UnitTypeLhs& /* lhs */, const UnitTypeRhs& /* rhs */) noexcept
 	{
 		static_assert(traits::is_same_scale<UnitTypeLhs, UnitTypeRhs>::value, "Cannot add units with different linear/non-linear scales.");

diff --git a/unitTests/main.cpp b/unitTests/main.cpp
@@ -927,6 +927,22 @@ TEST_F(UnitContainer, make_unit)
 	EXPECT_EQ(meter_t(5), dist);
 }
 
+namespace test {
+
+// Test types for https://github.com/nholthaus/units/issues/299
+struct Foo {
+	template<typename Unit>
+	Foo operator+(const unit_t<Unit>&) const {
+		return Foo{};
+	}
+};
+
+struct Bar : Foo {
+	// operator+ is implicitly inherited
+};
+
+}
+
 TEST_F(UnitContainer, unitTypeAddition)
 {
 	// units
@@ -963,6 +979,9 @@ TEST_F(UnitContainer, unitTypeAddition)
 
 	d = 1.0 + scalar_t(1.0);
 	EXPECT_NEAR(2.0, d, 5.0e-6);
+
+	test::Bar bar;
+	bar + a_m;
 }
 
 TEST_F(UnitContainer, unitTypeUnaryAddition)