DEV-444: Explicitly commit documents when indexing (#19)

BerkeleyLibrary · Jan 4, 2024 · 25a981f · 25a981f
1 parent 5fc6048
commit 25a981f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/lib/gingr/solr_indexer.rb b/lib/gingr/solr_indexer.rb
@@ -34,6 +34,7 @@ def index_directory(directory)
       Find.find(directory)
         .select(&method(:json_file?))
         .each(&method(:add))
+      @solr.commit
     end
 
     def update_reference_urls!(doc)

diff --git a/spec/solr_indexer_spec.rb b/spec/solr_indexer_spec.rb
@@ -50,15 +50,14 @@
 
   describe '#index_directory' do
     it 'adds all .json files to solr' do
-      files = ['foo.xml', 'bar.json', 'baz.json'].shuffle
-      expect(Find).to receive(:find).with('directory').and_return files
       Gingr::SolrIndexer.any_instance.stub(:add)
 
-      indexer = Gingr::SolrIndexer.new
-      indexer.index_directory('directory')
-      expect(indexer).to have_received(:add).with('bar.json')
-      expect(indexer).to have_received(:add).with('baz.json')
-      expect(indexer).not_to have_received(:add).with('foo.xml')
+      solr = spy(RSolr::Client)
+      indexer = Gingr::SolrIndexer.new(solr)
+      indexer.index_directory('spec/fixture/jsonfile')
+      expect(indexer).to have_received(:add).with 'spec/fixture/jsonfile/actual-point.json'
+      expect(indexer).to have_received(:add).with 'spec/fixture/jsonfile/berkeley_public_pdf.json'
+      expect(solr).to have_received(:commit).once
     end
   end