add test zipfile and log

BerkeleyLibrary · Dec 19, 2023 · 953c80c · 953c80c
1 parent 68642b6
commit 953c80c
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 1 deletion.
diff --git a/lib/gingr/data_handler.rb b/lib/gingr/data_handler.rb
@@ -32,6 +32,9 @@ def extract_zipfile(zip_file, to_dir_path)
           end
         end
         extracted_to_path
+      rescue Exception => e
+        Logging.logger.error("Failed to extract #{zip_file}: #{e.message}")
+        raise
       end
 
       def move_files(from_dir_path)
@@ -61,7 +64,7 @@ def clr_subdirectory(zip_file, to_dir_path)
         FileUtils.rm_r(subdir_path) if File.directory? subdir_path
         subdir_path
       rescue Errno::EACCES
-        logger.error("Permission denied: #{subdir_path}")
+        Logging.logger.error("Permission denied: #{subdir_path}")
         raise
       end
 

diff --git a/spec/fixture/zipfile/test-public_restricted.zip b/spec/fixture/zipfile/test-public_restricted.zip
diff --git a/spec/fixture/zipfile/test_public.zip b/spec/fixture/zipfile/test_public.zip
diff --git a/spec/fixture/zipfile/vector_public.zip b/spec/fixture/zipfile/vector_public.zip
diff --git a/spec/fixture/zipfile/vector_public_with_attachement.zip b/spec/fixture/zipfile/vector_public_with_attachement.zip
diff --git a/spec/fixture/zipfile/vector_public_with_collection.zip b/spec/fixture/zipfile/vector_public_with_collection.zip