DEV-429: Fix GeoServer URL references updates #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
danschmidt5189
commented
Dec 22, 2023
•
danschmidt5189
commented
- Fixes how GeoServer reference URLs are updated in the SolrIndexer.
- Refactors the GeoserverPublisher class to incorporate more of the logic currently in the ImportUtil class. Beefs up test coverage around its functionality, including adding a few end-to-end tests that rely on the geoservers running.
danschmidt5189
force-pushed
the
refactor-publisher
branch
4 times, most recently
from
bf356b9
to
6223bd5
Compare
danschmidt5189
commented
Dec 22, 2023
spec/geoserver_publisher_spec.rb
Outdated
| end | ||
| end | ||
|
|
||
| describe 'publish' do |
There was a problem hiding this comment.
These tests all hit the actual running GeoServers, so they're pretty valuable. We need a few more end-to-end tests like these (especially for the DataHandler and the logic in the Cli.all method).
danschmidt5189
changed the title
danschmidt5189
force-pushed
the
refactor-publisher
branch
5 times, most recently
from
99ab0d0
to
64bdab3
Compare
yzhoubk
reviewed
Dec 23, 2023
danschmidt5189
force-pushed
the
refactor-publisher
branch
from
64bdab3
to
e108ac3
Compare
- Fixes how GeoServer reference URLs are constructed. We now pass only the root path to the geoserver, omitting the /rest/ suffix pointing to the API. It's assumed that the API lives at /rest/ and the web service URLs live at /wms/ and /wfs/ - Refactors the GeoserverPublisher to incorporate much of the logic currently present in Cli or ImportUtil. The test suite has been updated and fleshed out accordingly. more stash more fixes gets suite passing
danschmidt5189
force-pushed
the
refactor-publisher
branch
from
e108ac3
to
201ebd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.