DP-827: Adds the watcher CLI command #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danschmidt5189
commented
Nov 14, 2023
lib/gingr/watcher.rb
Outdated
|
|
||
| def exec_gingr_with_file!(zipfile) | ||
| begin | ||
| stdout, stderr, status = Open3.capture3('gingr', 'all', zipfile, *options) |
There was a problem hiding this comment.
It would be preferable to call the code directly via Ruby, but that will require refactoring the existing code.
danschmidt5189
force-pushed
the
DP-827-adds_watcher_command
branch
4 times, most recently
from
a501202
to
103106b
Compare
danschmidt5189
force-pushed
the
DP-827-adds_watcher_command
branch
2 times, most recently
from
bd0ef0b
to
f3898fb
Compare
|
@yzhoubk unless you have objections, I'm going to merge this once the tests pass! Then we can get it on staging and begin testing. |
danschmidt5189
force-pushed
the
DP-827-adds_watcher_command
branch
from
f3898fb
to
34dbce1
Compare
danschmidt5189
force-pushed
the
DP-827-adds_watcher_command
branch
from
34dbce1
to
6537dcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.