DataDog shows spend metrics #14555
Merged
DataDog shows spend metrics #14555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
can you fix this test? @mubashir1osmani |
ishaan-jaff
requested changes
Sep 16, 2025
| import json | ||
| from datetime import datetime, date | ||
|
|
||
| def custom_json_encoder(obj): |
There was a problem hiding this comment.
this is a bad idea - we already have safe_dumps in the codebase
| # Get response cost for litellm_spend_metric | ||
| response_cost = standard_logging_payload.get("response_cost", 0.0) | ||
| if response_cost > 0: | ||
| spend_metrics["litellm_spend_metric"] = response_cost |
There was a problem hiding this comment.
this is confusing to ready. response_cost should get sent as response_cost
| metadata = standard_logging_payload.get("metadata", {}) | ||
|
|
||
| # API key max budget | ||
| user_api_key_max_budget = metadata.get("user_api_key_max_budget") |
There was a problem hiding this comment.
we must send user_api_key_spend too
|
thx @ishaan-jaff changes made 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Added these metrics in datadog logging
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🆕 New Feature