-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Add support for extended thinking in Anthropic's models via Bedrock's Converse API #15220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Sameerlite
merged 5 commits into
BerriAI:litellm_staging_oct
from
lcfyi:lcfyi/add-support-for-thinking
Oct 13, 2025
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
dd7d12e
Implement fix for thinking_blocks and converse API calls
lcfyi 1c3ec18
Add thinking literal
lcfyi 310e3b3
Fix mypy issues
lcfyi d07455b
Type fix for redacted thinking
lcfyi cee4b58
Merge branch 'litellm_staging_oct' into lcfyi/add-support-for-thinking
Sameerlite File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your code modifies the anthropic v1 messages api.
The error - is on the bedrock/converse_transformation for
/v1/chat/completionsAFAIKThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that was the API I was looking to fix initially (such that litellm works for Claude Code), so it's not fully related to the linked issue.
This change should fix models that are explicitly routing to
conversethough.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @krrishdholakia , This PR partially fixes #14194. This only takes care of streaming cases. The one problem people in that issue are facing is when they use Claude code with
http://localhost:4004/v1/messagesthey don't get back the thinking blocks in the streaming response. Which in turn makes Claude send a request without thinking block and it hence throws an error. So this is taking care of this case.I am raising a PR which will take care of the other issues. But this LGTM