(fix) Strip trailing slash in api_base for prometheus metrics

[owaisaamir]

Description by Korbit AI

What change is being made?

Remove trailing slashes from api_base in the prometheus metrics

Why are these changes being made?

Trailing slashes in api_base values can cause increased metric cardinality resulting in higher custom metrics cost in platform such as Datadog. This can also cause metrics not getting aggregated correctly for the same api_base.

example metrics with trailing slash:

litellm_deployment_success_responses_total{api_base="https://api.openai.com/v1/",api_key_alias="None",api_provider="openai",hashed_api_key="None",litellm_model_name="gpt-4o",model_id="0816ddaaddd6d762d4ba80f754895c0386360bdecc35430e5644bba7eb905b4f",requested_model="openai-gpt-4o",team="None",team_alias="None"} 4.0
litellm_deployment_success_responses_total{api_base="https://my-test-instance.openai.azure.com//openai/",api_key_alias="None",api_provider="azure",hashed_api_key="None",litellm_model_name="gpt-4o",model_id="4346bb17b8f946ed63b7a315d50b765be26387b0ffe3f1875c37a1efdcf0e82e",requested_model="azure-gpt-4o",team="None",team_alias="None"} 3.0
litellm_deployment_success_responses_total{api_base="https://api.openai.com/v1",api_key_alias="None",api_provider="openai",hashed_api_key="EMPTY",litellm_model_name="gpt-4o",model_id="0816ddaaddd6d762d4ba80f754895c0386360bdecc35430e5644bba7eb905b4f",requested_model="openai-gpt-4o",team="None",team_alias="None"} 1.0

By stripping trailing slashes, this improves metrics aggregation and reduces custom metrics cost.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
litellm	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 21, 2024 10:38pm

[korbit-ai]

I've completed my review and didn't find any issues... but I did find this squirrel.

         _.-"""-,
       .'  ..::. `\
      /  .::' `'` /
     / .::' .--.=;
     | ::' /  C ..\
     | :: |   \  _.)
      \ ':|   /  \
       '-, \./ \)\)
          `-|   );/
            '--'-'

Files scanned

​

File Path	Reviewed
litellm/router_utils/cooldown_callbacks.py	✅
litellm/integrations/prometheus.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

• You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
• You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
• Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
• Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
• Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

• Check out our docs on how you can make Korbit work best for you and your team.
• Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

​

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	✅

Issue Categories

​

Category	Enabled
Naming	✅
Database Operations	✅
Documentation	✅
Logging	✅
Error Handling	✅
Systems and Environment	✅
Objects and Data Structures	✅
Readability and Maintainability	✅
Asynchronous Processing	✅
Design Patterns	✅
Third-Party Libraries	✅
Performance	✅
Security	✅
Functionality	✅

Feedback and Support

• Tell us what you think of Korbit
• Schedule a call with our team
• Email us @ [email protected]