fix: dangling async tasks #7741
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create strong reference for all dangling async tasks
Not storing a strong reference to the task when calling
asyncio.create_task()can cause the task to be garbage collected at any time, leading to a "Task was destroyed but it is pending!" error.Relevant issues
Type
🐛 Bug Fix
🧹 Refactoring
Changes
This PR:
create_background_task()util function (inlitellm/litellm_core_utils/async_utils.py) that creates a task usingasyncio.create_task(), stores a strong reference to it in a module-level defined set, and add a callback to discard the task from the set when it's done.asyncio.create_task()that don't store a strong reference to the task withcreate_backgroud_task()