Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Message Editor Plugin #223

Open
wants to merge 112 commits into
base: main
Choose a base branch
from
Open

Custom Message Editor Plugin #223

wants to merge 112 commits into from

Conversation

ar-cyber
Copy link
Contributor

@ar-cyber ar-cyber commented Mar 5, 2025

No description provided.

@ar-cyber ar-cyber mentioned this pull request Mar 5, 2025
@ar-cyber
Copy link
Contributor Author

ar-cyber commented Mar 5, 2025

#222 (comment)

@ar-cyber
Copy link
Contributor Author

ar-cyber commented Mar 7, 2025

approx 180 commits

@ar-cyber
Copy link
Contributor Author

ar-cyber commented Mar 7, 2025

This is completely finished.

@ar-cyber ar-cyber marked this pull request as ready for review March 7, 2025 10:29
@ar-cyber
Copy link
Contributor Author

ar-cyber commented Mar 7, 2025

Now please DO NOT merge without review.

@Crazypersonalph
Copy link
Collaborator

These commit names are all over the place. Please fix that up by retroactively editing them, or rebasing your changes. In the git blame for the future, debugging will be hard without proper context.

@ar-cyber
Copy link
Contributor Author

These commit names are all over the place. Please fix that up by retroactively editing them, or rebasing your changes. In the git blame for the future, debugging will be hard without proper context.

I did the same thing for my previous merge.

@ar-cyber
Copy link
Contributor Author

and it would require me to force-push, closing this pr

@Crazypersonalph
Copy link
Collaborator

These commit names are all over the place. Please fix that up by retroactively editing them, or rebasing your changes. In the git blame for the future, debugging will be hard without proper context.

I did the same thing for my previous merge.

Just because you slipped it by in the past, doesn't give you a reason for why you should do it again 🤷‍♂️

@SethBurkart123
Copy link
Collaborator

Just because you slipped it by in the past, doesn't give you a reason for why you should do it again 🤷‍♂️

agreed right there..

@ar-cyber
Copy link
Contributor Author

ar-cyber commented Mar 12, 2025

Just because you slipped it by in the past, doesn't give you a reason for why you should do it again 🤷‍♂️

agreed right there..

Yeah but the issue is that I would have to rebase EVERY SINGLE commit and would have to force-push closing this pr.

@ar-cyber
Copy link
Contributor Author

Can someone actually have a look at this? I've tried to comment this to make it easier but it can be a bit weird.

@ar-cyber
Copy link
Contributor Author

I am going to merge this into a plugin. I will leave it open if it wants to be added as an official plugin.

@NIDNHU
Copy link
Contributor

NIDNHU commented Mar 26, 2025

what is even being done here? what was the goal, or is it just general tweaks?

@SethBurkart123 SethBurkart123 changed the title #222 Custom Message Editor Plugin Mar 26, 2025
@ar-cyber
Copy link
Contributor Author

what is even being done here? what was the goal, or is it just general tweaks?

It's the code for the custom message editor.

@NIDNHU
Copy link
Contributor

NIDNHU commented Mar 26, 2025

Oh ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants