Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 网络测试子页面重构 #3495

Merged
merged 2 commits into from
Oct 9, 2024
Merged

💄 网络测试子页面重构 #3495

merged 2 commits into from
Oct 9, 2024

Conversation

luojunyuan
Copy link
Contributor

@luojunyuan luojunyuan commented Sep 25, 2024

这个PR干了什么:
将 NetworkCheck 业务从 AcceleratorPageViewModel 中分离出来,单独成为一个 ViewModel

危险度:较低,业务逻辑没有任何改变,页面行为表现无不同。
影响范围:低,只与 网络测试页面 有关联。

可能的注意点:新的ViewModel的配置方式。

AcceleratorPage2.axaml
<spp:NetworkCheck DataContext="{Binding NetworkCheckControlViewModel}" />

AcceleratorPageViewModel.cs
public NetworkCheckControlViewModel NetworkCheckControlViewModel { get; } = new();

@luojunyuan luojunyuan marked this pull request as draft September 25, 2024 08:16
@luojunyuan luojunyuan changed the title 💄 网络测试子页面NAT检查部分代码重构 💄 网络测试子页面重构 Sep 25, 2024
@luojunyuan luojunyuan marked this pull request as ready for review September 25, 2024 10:02
@luojunyuan luojunyuan force-pushed the refactor_NetworkCheck branch from 5037247 to 81b31d3 Compare October 8, 2024 03:24
💄 网络测试子页面NAT检查部分逻辑重构

💄 网络测试子页面ViewModel重构

💄 网络测试子页面NAT检查部分逻辑重构

💄代码Clean,没有引用到的名称空间与枚举类型

💄 网络测试子页面NAT检查部分逻辑重构

💄 网络测试子页面ViewModel重构

💄 网络测试子页面NAT检查部分逻辑重构

💄代码Clean,没有引用到的名称空间与枚举类型
@luojunyuan luojunyuan force-pushed the refactor_NetworkCheck branch from 81b31d3 to 499edb4 Compare October 8, 2024 03:34
@rmbadmin rmbadmin merged commit e0c36a9 into develop Oct 9, 2024
1 check passed
@luojunyuan luojunyuan deleted the refactor_NetworkCheck branch November 27, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants