Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create statement page, Part 2 #20

Merged
merged 11 commits into from
Aug 13, 2024
Merged

Create statement page, Part 2 #20

merged 11 commits into from
Aug 13, 2024

Conversation

kidw0124
Copy link
Contributor

@kidw0124 kidw0124 commented Aug 6, 2024

Checklist

  • No Conflict 혹은 모두 해결 했나요?
  • Issue가 있다면 연결되어 있나요?
  • 공동 작업자를 모두 Co-author로 등록 하였나요?
  • Code Review 요청을 하였나요?

What is this request?

Brief Description

image image

Task Details

Please describe the task in detail.

  • Select Language section
  • Statement writing section

Done

Please summary what you did.

  • Create pages, and detect pages by '?language' query.
    • if language exists, then edit statement page
      image
    • if not, create new page(show only non-existing languages)
      image
      image
      • if click clone language, then show existing languages.
        image
        image

TODO(Optional)

Note the TODOs.

  • Fetch Data
  • "Draft" button(history)
  • if interactive, Show Interactive section and delete input/output
  • Include files for statement
  • Other features like preview, review, contain examples, ....

Additional Information

Decisions(Optional)

Describe some decisions you made.

  • Detect language status with search params(query)

Reference Materials (Optional)

Sorry, something went wrong.

@kidw0124 kidw0124 requested review from utilForever and plzfday August 6, 2024 11:14
@kidw0124 kidw0124 linked an issue Aug 6, 2024 that may be closed by this pull request
2 tasks
@plzfday
Copy link
Member

plzfday commented Aug 6, 2024

LGTM in general! Could you add a mobile view using responsive web design? You can refer to my work with sx having breakpoints.

@utilForever utilForever changed the title Create statement page, Part2 Create statement page, Part 2 Aug 7, 2024
Copy link
Member

@utilForever utilForever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check @plzfday's comment first?

Copy link
Member

@plzfday plzfday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks for your work

Copy link
Member

@utilForever utilForever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Ready to go~ 🚀

@kidw0124 kidw0124 merged commit b12ff88 into main Aug 13, 2024
1 check passed
@kidw0124 kidw0124 deleted the 14-pt-2-create-statement-page branch August 13, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pt 2. Create Statement page
3 participants