-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated manual curation for misannotated genes #55
Merged
luispedro
merged 4 commits into
BigDataBiology:main
from
Vedanth-Ramji:fix_manual_curation
Jun 24, 2024
Merged
Updated manual curation for misannotated genes #55
luispedro
merged 4 commits into
BigDataBiology:main
from
Vedanth-Ramji:fix_manual_curation
Jun 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Vedanth-Ramji
commented
Jun 24, 2024
- RSA2 was mapped to ARO:3004445. This mapping was changed in the ARO to ARO:3005440. db_harmonisation should pick this up, but temporarily the issue is resolved through manual curation.
- grdA_1_QJX10702 (in resfinder curation) & EstD (in resfinder & megares curation) were mapped directly to drug classes. They are now mapped to correct parent AROs. grdA_1_QJX10702 -> ARO:3007380 and EstD -> ARO:3000557
- RSA2 was mapped to ARO:3004445. This mapping was changed in the ARO to ARO:3005440. db_harmonisation should pick this up, but temporarily the issue is resolved through manual curation. - grdA_1_QJX10702 (in resfinder curation) & EstD (in resfinder & megares curation) were mapped directly to drug classes. They are now mapped to correct parent AROs. grdA_1_QJX10702 -> ARO:3007380 and EstD -> ARO:3000557
luispedro
requested changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See minor comment about markdown formatting
Do not remove the last column even when it's empty
Yes, this is now correct, Luis
…On Mon, 24 Jun 2024, at 3:25 PM, Vedanth Ramji wrote:
***@***.**** commented on this pull request.
In CHANGELOG.md <#55 (comment)>:
> @@ -10,6 +10,10 @@
### Manual curation
- argannot_curation: (Tet)tetH:EF460464:6286-7839:1554 was incorrectly annotated as ARO:3004797 which is a beta-lactamase due to a loose RGI hit. This was manually curated to ARO:3000175.
+- deeparg, megares, resfinderfg & sarg curation: ARO:3004445 -> ARO:3005440, this was due to a change in the ARO and the ARO number for the RSA2 gene changing. **db_harmonisation must change to take this into account**
+> Incorrectly curated genes. Previously, they were directly mapped to drug classes. Correct parent ARO term has now been given.
I have changed the formatting now. Is it ok?
—
Reply to this email directly, view it on GitHub <#55 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAATLZXNOGUP4XEG6TNQKFLZI6UTZAVCNFSM6AAAAABJZBS3WKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMZUGY3DOMZVHE>.
You are receiving this because you commented.Message ID: ***@***.***>
|
luispedro
reviewed
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.