Merge pull request #36

Add conditional imports and fiddle with protocol method types

README.md

@@ -143,3 +143,16 @@ To connect to a SQLite database in a read-only way, use the `uri=True` parameter
 ```python
 db_conn = sqlite3.connect("file:path/to/database.db?mode=ro", uri=True)
 ```
+
+## Contributing 🤝
+
+The Python packaging is managed with [Poetry](https://python-poetry.org/) (check which version in the [poetry.lock](poetry.lock) file), but that should be the only dependency.
+
+To get started, just clone the repo, install the dependencies, and enable [pre-commit](https://pre-commit.com/):
+
+```bash
+poetry install --sync --with dev,test
+pre-commit install --install-hooks
+```
+
+Happy coding! 🎉

db_query_profiler/query_timer.py

@@ -5,20 +5,25 @@
 import functools
 import inspect
 import pathlib
+import sys
 import timeit
 import warnings
 from typing import Any, Callable, Generator, List, Union
 
 import tqdm
-from typing_extensions import Protocol
+
+if sys.version_info[:3] >= (3, 8, 0):
+    from typing import Protocol
+else:
+    from typing_extensions import Protocol
 
 
 class DatabaseConnection(Protocol):
     """
     Database connector to run SQL against the database.
     """
 
-    def execute(self, *args, **kwargs) -> Any:
+    def execute(self, *args: Any, **kwargs: Any) -> Any:
         """
         Execute a statement.
         """
@@ -142,7 +147,9 @@ def _create_query_runners(
         Runner(
             # runner=lambda: db_conn.execute(file.read_text()),  # lambda is only keeping the last query for each runner
             runner=functools.partial(
-                _execute_query, query=file.read_text(), db_conn=db_conn
+                _execute_query,
+                query=file.read_text(),
+                db_conn=db_conn,
             ),
             name=file.name,
         )

pyproject.toml

@@ -14,7 +14,7 @@ packages = [{include = "db_query_profiler"}]
 [tool.poetry.dependencies]
 python = "^3.7"
 tqdm = "^4"
-typing-extensions = "^4"
+typing-extensions = { version = "^4", python = "<3.8" }
 
 [tool.poetry.group.dev]
 optional = true