Use package_dir name for src/tests and .gitignore #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobleesj
commented
Sep 27, 2024
| @@ -16,7 +16,7 @@ | |||
| """{{ cookiecutter.project_short_description }}""" | |||
|
|
|||
| # package version | |||
| from {{cookiecutter.package_dist_name}}.version import __version__ | |||
| from {{cookiecutter.package_dir_name}}.version import __version__ | |||
There was a problem hiding this comment.
package_dir_name being bg_mpl_stylesheets
|
@sbillinge Could you please review this as well? |
sbillinge
reviewed
Oct 2, 2024
There was a problem hiding this comment.
I thought I reviewed this already but I don't see my comments. I think this will break our diffpy packages so we don't want to merge this. We need a different way that handles both the src/diffpy/<package> and the src/<package_name> patterns somehow. The former would be packages on the diffpy org and the latter on the billingegroup org
|
I will keep this PR open and make an update later we can address both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159
Tested locally
Next, time to fix the
auto_api.pyin therelease scriptsrepo as addressed by you: Billingegroup/bg-mpl-stylesheets#65 (comment)Update:
auto_api.pyis fixed