Skip to content

fix: fixing search to use join instead of subquery #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 9.x
Choose a base branch
from

Conversation

binaryk
Copy link
Collaborator

@binaryk binaryk commented Aug 13, 2025

No description provided.

Copy link

what-the-diff bot commented Aug 13, 2025

PR Summary

  • Improvement in Querying Process
    Updated the 'filter' method that helps remove unnecessary database operations, by intelligently checking if a 'join' operation is required before performing it. This makes our system's data querying more efficient.

  • Application of Search Conditions
    The searching method has been replaced to optimize searching through related data. It now provides an option for case-sensitive searches, making the results more precise.

  • Removal of Redundant Filtering Logic
    In 'RepositorySearchService.php', ineffective and unused filtering logic has been removed. While the functionality remains the same, this change makes the codebase cleaner and easier to manage.

  • Enhanced Code Clarity and Efficiency
    The overall restructuring of the code not only promotes better understanding for developers but also cuts down unnecessary database operations. Hence, this results in improved performance and code maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant