Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the metadata for a DefinedTerm Profile #799

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

sneumann
Copy link
Contributor

Hi,
I have read https://github.com/BioSchemas/specifications/blob/master/.github/readme.md
and this PR is to "For new profiles: steps 1..4".
Please double check the line that does not start with a dash, whether I understood things correctly:
DefinedTerm,,,schema:DefinedTerm,
The corresponding ./specifications/DefinedTerm/jsonld/DefinedTerm_v0.1-DRAFT.jsonld
is sitting in PR https://github.com/sneumann/specifications/pull/new/fix/issue652
Yours,
Steffen
P.S.: this could actually be a PR better suitable for schema.science, since there is nothing bio in it ...
but schemas.science does not yet have all the github action magic.

@ljgarcia ljgarcia mentioned this pull request Dec 14, 2023
@gtsueng gtsueng merged commit 7489142 into BioSchemas:master Dec 14, 2023
@sneumann
Copy link
Contributor Author

Hi, I think we are not entirely there yet, and I need help what to do:

  1. we now have https://github.com/BioSchemas/specifications/tree/master/DefinedTerm merged into the specifications.
  2. There is no https://bioschemas.org/profiles/DefinedTerm/ yet
  3. I thought this happens through this Adding the metadata for a DefinedTerm Profile #799 here (Defined terms #801 was not merged as it duplicates Adding the metadata for a DefinedTerm Profile #799)
    => What do I have to do ?
    I did notice that
    latest_publication: 0.1 -DRAFT

    might contain an extra space (sorry, my bad!)
    and the rendered CSV https://github.com/BioSchemas/bioschemas.github.io/blob/master/_data/metadata_mapping.csv
    does look broken :-(
    Yours, Steffen

@gtsueng
Copy link
Contributor

gtsueng commented Jan 16, 2024

@sneumann
The space was corrected in this pull request which contains the autogenerated profile

The reviewer requested the following which is why it hasn't been merged yet:

The profile created from GitHub actions looks fine (after updating hierarchy and redirections which do not work well in GitHub actions). However, some information is missing and should be added to this PR.
@sneumann @gtsueng @ivanmicetic could you please add the use cases? They should go to /useCases/DefinedTerm and also the group this profile should go to? I would suggest Dataset.
There are no embedded examples in the page, cannot those be created with DDE as well? If not, see if you can add a couple by hand. Not mandatory/blocking but nice to have.

How to help. For the branch referenced in this pull request:

  1. Add a DefinedTerm.md page to this directory with the use case: https://github.com/BioSchemas/bioschemas.github.io/tree/2023_12_21-18_29/pages/_useCases
  2. Add examples to the page manually as this is not supported by the DDE

@sneumann
Copy link
Contributor Author

Ok, I have started the UseCases in https://github.com/sneumann/bioschemas.github.io/blob/2023_12_21-18_29-sneumann/pages/_useCases/DefinedTerm.md,
because I don't know how to augment the PR #806 and will create a new PR later, or someone merges my addition from my branch into #806 once ready.

"Add examples to the page manually" means ignoring

# DO NOT MANUALLY EDIT THE CONTENT

and creating snippets like
https://github.com/sneumann/bioschemas.github.io/blob/0f56835d50154e689ad873a6ad0161b7620f92c6/pages/_profiles/Dataset/1.0-RELEASE.html#L46
in https://github.com/sneumann/bioschemas.github.io/blob/0f56835d50154e689ad873a6ad0161b7620f92c6/pages/_profiles/DefinedTerm/0.1-DRAFT.html#L22
Correct ?

@gtsueng
Copy link
Contributor

gtsueng commented Jan 16, 2024

@sneumann that is correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants