Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable .gsutil_is_uri checks for destination inputs in gsutil cp #83

Merged
merged 4 commits into from
Aug 22, 2023

Conversation

LiNk-NY
Copy link
Contributor

@LiNk-NY LiNk-NY commented Aug 17, 2023

.gsutil_requesterpays_flag interface allows for destination inputs with a default of ""

@LiNk-NY LiNk-NY requested a review from mtmorgan August 17, 2023 16:10
R/gsutil.R Outdated Show resolved Hide resolved
@mtmorgan
Copy link
Collaborator

OK; since I guess this is relatively 'expensive' does it make sense for gsutil_requesterpays() to return scalar TRUE if any location is requester pays, and implement this as a loop that exits on first detection of requester pays?

@LiNk-NY
Copy link
Contributor Author

LiNk-NY commented Aug 22, 2023

Thanks Martin @mtmorgan
I've made the change to loop through the buckets and break when requester pays is enabled in one of them.

@LiNk-NY LiNk-NY merged commit 820ef90 into devel Aug 22, 2023
@LiNk-NY LiNk-NY deleted the requesterpays_destination_82 branch August 22, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants