Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support custom configure_optimizers method and avoid from saving random model by default #367

Merged
merged 5 commits into from
Sep 15, 2024
Merged

support custom configure_optimizers method and avoid from saving random model by default #367

merged 5 commits into from
Sep 15, 2024

Conversation

mosheraboh
Copy link
Collaborator

No description provided.

SagiPolaczek
SagiPolaczek previously approved these changes Sep 15, 2024
View reviewed changes
Copy link
Collaborator

@SagiPolaczek SagiPolaczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM :)

I would consider to change the type hint of optimizers_and_lr_schs into:

        optimizers_and_lr_schs: Union[dict,callable] = None,

@mosheraboh mosheraboh merged commit 00f7044 into master Sep 15, 2024
5 checks passed
@mosheraboh mosheraboh deleted the mammal branch September 15, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagiPolaczek SagiPolaczek SagiPolaczek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mosheraboh @SagiPolaczek