Integrate isort
#385
Integrate isort
#385
Conversation
There was a problem hiding this comment.
Hi @RomiPolaczek ✋
Great work!
Approving with one question inline
(making sure that the precommit step both checks and applies fixes)
| @@ -25,3 +25,7 @@ repos: | |||
| args: | |||
| - --remove-empty-cells | |||
| - --preserve-cell-outputs | |||
| - repo: https://github.com/pycqa/isort | |||
There was a problem hiding this comment.
I assume this step checks and applies fixes if necessary, right?
Is the order important? meaning if black should run before or after.
There was a problem hiding this comment.
Hi @mosheraboh,
Thank you for the feedback! 🙌
Yes, the pre-commit step for isort both checks and applies fixes as necessary to ensure imports are properly sorted.
As for the order: It's generally recommended that isort runs before black, as isortorganizes imports and black formats the entire file. This avoids potential conflicts where black might undo some of isort's changes.
I’ve now pushed a commit that updates the order in .pre-commit-config.yaml to ensure isort runs before black.
Goal
Arrange Fuse's code base, and particular the imports in each file.
Related issue: #214
Key files:
.pre-commit-config.yaml: Addisortas a pre-commit hook to enforce consistent import order./.github/workflows/lint.yaml: Addedisortinto Github actions for automated linting during CI.setup.cfg: Configuredisortto use theblackprofile, ensuring alignment between import sorting and code formatting standards.