encapsulate SubmitDelegatedFallbackDirect func

[Intizar-T]

Description

Please include a summary of the changes and the related issue.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes #1905

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist before requesting a review

• I have performed a self-review of my code.
• If it is a core feature, I have added thorough tests.

Deployment

• Should publish npm package
• Should publish Docker image

[coderabbitai]

Walkthrough

Walkthrough

The changes involve a significant refactor of the SubmitDelegatedFallbackDirect method in the ChainHelper class. The method's internal logic has been split into two new helper methods, submitDelegated and submitDirect, which handle fee-delegated and direct transaction submissions, respectively. This restructuring enhances code readability, maintainability, and error handling.

Changes

Files	Change Summary
node/pkg/chain/helper/helper.go	Refactored SubmitDelegatedFallbackDirect method; added submitDelegated and submitDirect methods for improved logic separation.

Assessment against linked issues

Objective	Addressed	Explanation
Encapsulate SubmitDelegatedFallbackDirect internal logics (#[1905])	✅
Take parameter for customizable max retrial (#[1906])	✅
Jump to direct submission on signing error (#[1906])	❌	The current implementation still retries after a signing error.

Possibly related issues

• (OraklNode) Improve SubmitDelegatedFallbackDirect function #1906: The changes partially address the customization of the max retrial but do not implement the immediate jump to direct submission on signing errors.

🐇 In the code where bunnies hop,
Refactoring helps the logic pop!
With helpers neat and clean,
Errors handled, a smooth routine.
Hooray for changes, let’s all cheer,
For clearer paths and code we hold dear! 🥕✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 52f309f and b2c8740.

Files selected for processing (1)

• node/pkg/chain/helper/helper.go (2 hunks)

Additional comments not posted (3)

node/pkg/chain/helper/helper.go (3)

252-259: LGTM!

The refactoring of SubmitDelegatedFallbackDirect to call submitDelegated and submitDirect improves readability and maintainability.

The code changes are approved.

---

261-297: LGTM!

The submitDelegated function encapsulates the logic for fee-delegated transactions, improving modularity. The retry logic and error handling are well-implemented.

The code changes are approved.

---

Line range hint 299-317: LGTM!

The submitDirect function encapsulates the logic for direct transactions, improving modularity. The retry logic and error handling are well-implemented.

The code changes are approved.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b2c8740 and c2c5096.

Files selected for processing (1)

• node/pkg/chain/helper/helper.go (3 hunks)

Files skipped from review as they are similar to previous changes (1)

• node/pkg/chain/helper/helper.go

[nick-bisonai]

lgtm!