Fix member variable naming #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinaliBQ
approved these changes
Sep 25, 2025
There was a problem hiding this comment.
LGTM! I think we should probably include this commit in apache#47658 as well
Comment on lines
-152
to
-154
| std::unique_ptr<Window> common_content; | ||
|
|
||
| std::unique_ptr<Window> advanced_content; |
There was a problem hiding this comment.
I suppose common_content and advanced_content are not actually needed
There was a problem hiding this comment.
Correct. They were not used anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We want our code to adhere to Arrow's expected naming conventions.
What changes are included in this PR?
Private/protected member variables are renamed from
m_member_vartomember_var_.Public member variables are named
member_var(without them_prefix or_suffix).Are these changes tested?
N/A
Are there any user-facing changes?
No