php8 compatible #909
Open
php8 compatible #909
+36
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you want to use bitwaps with php>8.0 you will run into issues signing a transaction with SplFixedArray as some functions are deprecated now. This PR fixes the issue and allow to sign BTC transactions >php8.0 Reference: https://github.com/php/php-src/blob/e4e2541c1a90daf708ab1ee4d44f2ab2883ce84b/UPGRADING#L515-L520 |
|
For information we maintain a fork to be PHP 8 compatible (https://github.com/ProtonMail/bitcoin-php) |
BafS
approved these changes
Oct 11, 2024
|
I know it's been a while since I've been active, but I'm glad and thankful to see this PR. I'll try review and tag in the coming days so you can keep working. |
|
@afk11 it would be great to have more contributors for this project if you don't have time, or to officially archive it and link a fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow mdanter/ecc to be 1.0.0 - 0.5.0 does not allow php8