VSF2-54 - throws error on no token found, adjusts tests

BitBagCommerce · Jun 16, 2023 · 7ce67f7 · 7ce67f7
1 parent 0188289
commit 7ce67f7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/features/shop/account/resetting_password.feature b/features/shop/account/resetting_password.feature
@@ -34,4 +34,4 @@ Feature: Resetting one customer password
         And I prepare check reset password token operation for invalid token
         And I send that GraphQL request
         Then I should receive a JSON response
-        And This response should contain pattern '/^\{"data":\{"password_reset_tokenUser":null\}\}$/'
+        And This response should contain pattern '/"data":\{"password_reset_tokenUser":null\}/'
diff --git a/spec/Resolver/Query/PasswordResetTokenResolverSpec.php b/spec/Resolver/Query/PasswordResetTokenResolverSpec.php
@@ -62,6 +62,7 @@ public function it_should_return_null_on_invalid_token(
 
         $userRepository->findOneBy(['passwordResetToken' => $token])->willReturn(null);
 
-        $this->__invoke(null, $context)->shouldReturn(null);
+        $this->shouldThrow(\RuntimeException::class)
+            ->during('__invoke', [null, $context]);
     }
 }
diff --git a/src/Resolver/Query/PasswordResetTokenResolver.php b/src/Resolver/Query/PasswordResetTokenResolver.php
@@ -24,7 +24,7 @@ public function __construct(UserRepositoryInterface $userRepository)
         $this->userRepository = $userRepository;
     }
 
-    public function __invoke($item, array $context): ?ShopUserInterface
+    public function __invoke($item, array $context): ShopUserInterface
     {
         $token = $context['args']['passwordResetToken'];
         /** @var ?ShopUserInterface $user */
@@ -34,6 +34,6 @@ public function __invoke($item, array $context): ?ShopUserInterface
             return $user;
         }
 
-        return null;
+        throw  new \RuntimeException('Token not found');
     }
 }