リファクタリングおよび後手番、駒落ちが正常に動作するところまで修正完了 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix - PieceTypeから駒の画像をManagementクラス内で取得する構成に修正およびPieceTypeのEnumを修正
Piece内に画像変更の処理を集約
Fix - 持ち駒関連の処理をコンパクト化
Fix - 持ち駒情報更新判定のタイミングを修正
プレイヤーが後手の場合に駒が反転してしまう現象を修正
youkura-ikuzee
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
後手番および駒落ちでゲームが正常に進行するところまで修正完了しました。