Merge pull request #4907 from BitGo/WP-2664-e-toro-issue-with-the-new…

…-bitgo-express fix: add wallet type check for sign transaction
BitGo · Sep 16, 2024 · 65b0db0 · 65b0db0
2 parents a10dac8 + ddc04f5
commit 65b0db0
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/modules/sdk-core/src/bitgo/wallet/wallet.ts b/modules/sdk-core/src/bitgo/wallet/wallet.ts
@@ -1831,7 +1831,12 @@ export class Wallet implements IWallet {
       params.txPrebuild = { txRequestId };
     }
 
-    if (params.walletPassphrase && !(params.keychain || params.key)) {
+    if (
+      params.walletPassphrase &&
+      !(params.keychain || params.key) &&
+      (this.type() === 'hot' || this.type() === undefined)
+    ) {
+      // this logic should only apply to hot wallets
       if (!_.isString(params.walletPassphrase)) {
         throw new Error('walletPassphrase must be a string');
       }