Skip to content

Commit

Permalink
Merge pull request #3793 from BitGo/EA-944-pass-pendingapprovalid-in-…
Browse files Browse the repository at this point in the history
…buildparams

fix(sdk-core): add pendingapproval id in build api
  • Loading branch information
gianchandania authored Aug 9, 2023
2 parents 20a6fe6 + 3ace9ac commit a4278c4
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export interface ApproveOptions {
tx?: string;
xprv?: string;
previewPendingTxs?: boolean;
pendingApprovalId?: string;
}

export interface PendingApprovalInfo {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ export class PendingApproval implements IPendingApproval {

let canRecreateTransaction = true;
params.previewPendingTxs = true;
params.pendingApprovalId = this.id();
/*
* Cold wallets cannot recreate transactions if the only thing provided is the wallet passphrase
*
Expand Down
1 change: 1 addition & 0 deletions modules/sdk-core/src/bitgo/wallet/wallet.ts
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ export class Wallet implements IWallet {
'noSplitChange',
'numBlocks',
'nonce',
'pendingApprovalId',
'preview',
'previewPendingTxs',
'receiveAddress',
Expand Down

0 comments on commit a4278c4

Please sign in to comment.