Merge pull request #4442 from BitGo/BTC-1084-revert-clone

Revert "feat: protect pass by value when sending data out"
BitGo · Apr 17, 2024 · e9d620f · e9d620f
2 parents a8528d3 + ef1497f
commit e9d620f
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 14 deletions.
diff --git a/modules/sdk-api/src/bitgoAPI.ts b/modules/sdk-api/src/bitgoAPI.ts
@@ -683,12 +683,12 @@ export class BitGoAPI implements BitGoBase {
    * Caution: contains sensitive data
    */
   toJSON(): BitGoJson {
-    return structuredClone({
+    return {
       user: this._user,
       token: this._token,
       extensionKey: this._extensionKey ? this._extensionKey.toWIF() : undefined,
       ecdhXprv: this._ecdhXprv,
-    });
+    };
   }
 
   /**

diff --git a/modules/sdk-coin-ada/src/lib/transactionBuilder.ts b/modules/sdk-coin-ada/src/lib/transactionBuilder.ts
@@ -503,6 +503,6 @@ export abstract class TransactionBuilder extends BaseTransactionBuilder {
   }
 
   private getAllSignatures(): Signature[] {
-    return structuredClone(this._initSignatures.concat(this._signatures));
+    return this._initSignatures.concat(this._signatures);
   }
 }
diff --git a/modules/sdk-coin-algo/src/lib/transaction.ts b/modules/sdk-coin-algo/src/lib/transaction.ts
@@ -139,15 +139,15 @@ export class Transaction extends BaseTransaction {
   }
 
   get signers(): string[] {
-    return structuredClone(this._signers);
+    return this._signers;
   }
 
   set signedBy(signer: string[]) {
     this._signedBy = signer;
   }
 
   get signedBy(): string[] {
-    return structuredClone(this._signedBy);
+    return this._signedBy;
   }
 
   /**

diff --git a/modules/sdk-coin-xtz/src/lib/transaction.ts b/modules/sdk-coin-xtz/src/lib/transaction.ts
@@ -294,7 +294,7 @@ export class Transaction extends BaseTransaction {
   }
 
   get owners(): string[] {
-    return structuredClone(this._owners);
+    return this._owners;
   }
 
   /**

diff --git a/modules/sdk-core/src/bitgo/address-book/address-book.ts b/modules/sdk-core/src/bitgo/address-book/address-book.ts
@@ -42,7 +42,7 @@ export class AddressBook implements IAddressBook {
      * TODO(PX-2794): Move to structuredClone
      * https://github.com/BitGo/BitGoJS/pull/4119
      */
-    return structuredClone(this._listing);
+    return JSON.parse(JSON.stringify(this._listing));
   }
 
   /**

diff --git a/modules/sdk-core/src/bitgo/wallet/wallet.ts b/modules/sdk-core/src/bitgo/wallet/wallet.ts
@@ -271,7 +271,7 @@ export class Wallet implements IWallet {
   }
 
   public flags(): { name: string; value: string }[] {
-    return structuredClone(this._wallet.walletFlags ?? []);
+    return this._wallet.walletFlags ?? [];
   }
 
   public flag(name: string): string | undefined {
@@ -282,7 +282,7 @@ export class Wallet implements IWallet {
    * Get the public object ids for the keychains on this wallet.
    */
   public keyIds(): string[] {
-    return structuredClone(this._wallet.keys);
+    return this._wallet.keys;
   }
 
   /**
@@ -317,7 +317,7 @@ export class Wallet implements IWallet {
    * Get wallet properties which are specific to certain coin implementations
    */
   coinSpecific(): WalletCoinSpecific | undefined {
-    return structuredClone(this._wallet.coinSpecific);
+    return this._wallet.coinSpecific;
   }
 
   /**
@@ -831,7 +831,7 @@ export class Wallet implements IWallet {
     }
     const url = this.url(`/address/${encodeURIComponent(query)}/deployment`);
     this._wallet = await this.bitgo.post(url).send(params).result();
-    return structuredClone(this._wallet);
+    return this._wallet;
   }
 
   /**
@@ -858,7 +858,7 @@ export class Wallet implements IWallet {
     }
     const url = this.url(`/address/${encodeURIComponent(query)}/tokenforward`);
     this._wallet = await this.bitgo.post(url).send(params).result();
-    return structuredClone(this._wallet);
+    return this._wallet;
   }
 
   /**
@@ -2479,7 +2479,7 @@ export class Wallet implements IWallet {
    * Extract a JSON representable version of this wallet
    */
   toJSON(): WalletData {
-    return structuredClone(this._wallet);
+    return this._wallet;
   }
 
   /**
@@ -3335,7 +3335,7 @@ export class Wallet implements IWallet {
     }
     const url = this.url('/fundForwarder');
     this._wallet = await this.bitgo.post(url).send(params).result();
-    return structuredClone(this._wallet);
+    return this._wallet;
   }
 
   /**