Merge pull request #4344 from BitGo/PX-3270-wallet-share

feat(sdk-core): Add support for wallet shares without admin approvals
BitGo · Mar 13, 2024 · ebc1b16 · ebc1b16
2 parents 387b99a + 734478d
commit ebc1b16
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/modules/sdk-core/src/bitgo/wallet/iWallet.ts b/modules/sdk-core/src/bitgo/wallet/iWallet.ts
@@ -452,6 +452,7 @@ export interface CreateShareOptions {
    * A falsy value is expected to throw an API error if an empty or undefined `keychain` is provided.
    */
   skipKeychain?: boolean;
+  disableAdminApproval?: boolean;
 }
 
 export interface ShareWalletOptions {
@@ -465,6 +466,10 @@ export interface ShareWalletOptions {
    */
   skipKeychain?: boolean;
   disableEmail?: boolean;
+  /**
+   * If true, skips admin approval for the share, it will become active immediately.
+   */
+  disableAdminApproval?: boolean;
 }
 
 export interface RemoveUserOptions {

diff --git a/modules/sdk-core/src/bitgo/wallet/wallet.ts b/modules/sdk-core/src/bitgo/wallet/wallet.ts
@@ -1481,6 +1481,10 @@ export class Wallet implements IWallet {
       throw new Error('Expected disableEmail to be a boolean.');
     }
 
+    if (params.disableAdminApproval !== undefined && !_.isBoolean(params.disableAdminApproval)) {
+      throw new Error('Expected disableAdminApproval to be a boolean.');
+    }
+
     if (!_.isString(params.email)) {
       throw new Error('missing required string parameter email');
     }
@@ -1537,6 +1541,7 @@ export class Wallet implements IWallet {
       disableEmail: params.disableEmail,
       skipKeychain: Object.keys(sharedKeychain ?? {}).length === 0,
       keychain: Object.keys(sharedKeychain ?? {}).length === 0 ? undefined : sharedKeychain,
+      disableAdminApproval: params.disableAdminApproval,
     };
 
     return await this.createShare(options);