Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk-coin-inj): inj sdk init #3676

Closed
wants to merge 1 commit into from
Closed

feat(sdk-coin-inj): inj sdk init #3676

wants to merge 1 commit into from

Conversation

DinshawKothari
Copy link
Contributor

Ticket: BG-79064

@DinshawKothari DinshawKothari force-pushed the BG-79064-inj-sdk-addition branch 3 times, most recently from d5fe470 to 488fbb1 Compare June 21, 2023 09:15
mmcshinsky-bitgo
mmcshinsky-bitgo requested changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@mmcshinsky-bitgo mmcshinsky-bitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked until rel/latest back merge.

modules/account-lib/tsconfig.json Outdated
@@ -49,6 +49,9 @@
{
"path": "../sdk-coin-hbar"
},
{
"path": "../sdk-coin-inj"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this coin in account-lib or can we just use bitgo?

@socket-security
Copy link

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
@bitgo/statics 🆕 16.2.0 None +0 6.57 MB mmcshinsky-bitgo

Footnotes

  1. https://docs.socket.dev ↩

@DinshawKothari DinshawKothari force-pushed the BG-79064-inj-sdk-addition branch 3 times, most recently from 690fabb to c30b24f Compare June 22, 2023 13:35
@DinshawKothari
Copy link
Contributor Author

Closed this due to build issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcshinsky-bitgo mmcshinsky-bitgo mmcshinsky-bitgo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DinshawKothari @mmcshinsky-bitgo