Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-coin-ada): parse partially witnessed tx hex #3683

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

evanzbitgo
Copy link
Contributor

@evanzbitgo evanzbitgo commented Jun 21, 2023

1. Txn builder's init method should parse partially witnessed txn hex and preserve signature

We will use it to parse the partially witnessed pledge txn hex from API users

2. Bump CSL version

Stale CSL fails to parse txn built by latest cardano-cli since cardano-cli does not follow the same conventions as CSL to serialize a CBOR txn. Bumping CSL version helps successful parsing of cardano-cli's serialization
Deserialization failed in Transaction.body.TransactionBody.outputs.TransactionOutputs.TransactionOutput because: Invalid cbor: not the right type, expected Array byte received Map.

3. Replace unit test raw txn hex with the ones generated by cardano-cli

4. Expose signatures in txn wrapper

Add signatures to our txn wrapper besides the native CSL txn to avoid confusing signature counts in txn wrapper

EA-621

@socket-security
Copy link

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
@emurgo/cardano-serialization-lib-browser 🆕 11.4.0 None +0 3.31 MB lisicky_emurgo
@emurgo/cardano-serialization-lib-nodejs 🆕 11.4.0 None +0 3.31 MB lisicky_emurgo

Footnotes

  1. https://docs.socket.dev

@evanzbitgo evanzbitgo force-pushed the EA-621-fix-ada-serialization-lib branch 5 times, most recently from d42d603 to 4e94931 Compare June 22, 2023 23:01
@evanzbitgo evanzbitgo changed the title chore(sdk-coin-ada): bump ada serialization lib version chore(sdk-coin-ada): bump CSL version and other Jun 22, 2023
Support parsing partially signed tx hex; bump CSL version; expose signature in ADA txn wrapper

EA-621
@evanzbitgo evanzbitgo force-pushed the EA-621-fix-ada-serialization-lib branch from 4e94931 to dcfa939 Compare June 23, 2023 04:12
@evanzbitgo evanzbitgo changed the title chore(sdk-coin-ada): bump CSL version and other feat(sdk-coin-ada): bump CSL version and other Jun 23, 2023
@evanzbitgo evanzbitgo changed the title feat(sdk-coin-ada): bump CSL version and other feat(sdk-coin-ada): parse partially signed tx hex Jun 23, 2023
@evanzbitgo evanzbitgo changed the title feat(sdk-coin-ada): parse partially signed tx hex feat(sdk-coin-ada): parse partially witnessed tx hex Jun 23, 2023
@evanzbitgo evanzbitgo marked this pull request as ready for review June 23, 2023 04:40
@evanzbitgo evanzbitgo requested review from a team as code owners June 23, 2023 04:40
@evanzbitgo evanzbitgo merged commit ea63ffa into master Jun 23, 2023
@evanzbitgo evanzbitgo deleted the EA-621-fix-ada-serialization-lib branch June 23, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants