feat: add cold wallet feature flags #3685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitgoAaron
commented
Jun 22, 2023
| @@ -286,7 +314,7 @@ export const coins = CoinMap.fromCoins([ | |||
| Networks.test.bitcoinGold, | |||
| UnderlyingAsset.BTG, | |||
| BaseUnit.BTC, | |||
| BTG_FEATURES | |||
| BTG_FEATURES.filter((f) => f !== CoinFeature.MULTISIG_COLD) | |||
There was a problem hiding this comment.
technically we shouldn't even have this as an option in statics, since there is no such coin implementation for tbtg, only the mainnet one but I'd rather not open this change up to also include breaking changes if not necessary.
zahin-mohammad
previously approved these changes
Jun 22, 2023
mmcshinsky-bitgo
previously approved these changes
Jun 22, 2023
- identify precisely which coins support cold wallets Ticket: CE-1156
bitgoAaron
dismissed stale reviews from mmcshinsky-bitgo and zahin-mohammad
via
a496574
bitgoAaron
force-pushed
the
aloe/coldFeatureFlags
branch
from
25d10c5
to
a496574
Compare
mmcshinsky-bitgo
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CE-1156