fix(sdk-core): do not treat sol as a utxo-coin for approval #3687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solana _and_ Bitcoin-like coins have `network` property. This will now only detect Bitcoin-like coins as intended. Should fix approving pending approvals for Solana. Issue: BG-79393
davidkaplanbitgo
approved these changes
Jun 22, 2023
|
Yeah, was thinking same. Need a more robust way to decide whether a transaction can/should be rebuilt 😢 Also should just be able to rebuild even without recipients, but that's a whole other thing around communicating intent consistently through the build/approve/sign/approve/send flow. |
alebusse
approved these changes
Jun 22, 2023
linyah9912
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solana and Bitcoin-like coins have
networkproperty. This will now only detect Bitcoin-like coins as intended.Should fix approving pending approvals for Solana.
Issue: BG-79393