fix(sdk-core): fix createTssBitGoKeyFromOvcShares method #3694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alebusse
force-pushed
the
WP-152-fix-createTssBitGoKeyFromOvcShares-method
branch
from
4f7ae7b
to
4370604
Compare
pranavjain97
previously approved these changes
Jun 26, 2023
alebusse
force-pushed
the
WP-152-fix-createTssBitGoKeyFromOvcShares-method
branch
from
4370604
to
79e6164
Compare
OttoAllmendinger
requested changes
Jun 27, 2023
| // BitGo to Backup (OVC-2) | ||
| 2: t.type({ | ||
| bitgoToOvcShare: OvcShare, | ||
| export const BitGoToOvcJSON = t.strict( |
There was a problem hiding this comment.
you can create a type from this.
| @@ -374,37 +374,39 @@ export class Keychains implements IKeychains { | |||
|
|
|||
| // Create JSON data with platform shares for OVC-1 and OVC-2 | |||
| const bitgoToOvcOutput = { | |||
There was a problem hiding this comment.
you can add a type to this from the codec type.
changed the method response to match with OVC expected JSON, wrapping the response in wallet: {...}
and renaming the walletgpgkeys field
WP-152
alebusse
force-pushed
the
WP-152-fix-createTssBitGoKeyFromOvcShares-method
branch
from
79e6164
to
70e3e13
Compare
pranavjain97
approved these changes
Jun 27, 2023
zahin-mohammad
approved these changes
Jun 27, 2023
OttoAllmendinger
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed the method response to match with OVC expected JSON, wrapping the response in wallet: {...} and renaming the walletgpgkeys field
WP-152