-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(abstract-utxo): update the keySignature verification network #3697
Conversation
a3f1219
to
00ffc21
Compare
00ffc21
to
26fbaa1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the commit messages in this PR to include an imperative mood statement of what changed, and why.
Example:
fix(abstract-utxo): always use bitcoin network for validating secondary key signatures
Key signatures are always generated with the bitcoin network because it is not always known which coin they will be used with. Without this change altcoin signatures would fail verification in some contexts.
For a rousing review of commit messages check out my recent brown bag talk :-D
9536c29
to
99a1ff7
Compare
…ary key signatures Key signatures are always generated with the bitcoin network because it is not always known which coin they will be used with. Without this change altcoin signatures would fail verification in some contexts. BG-79423
1dc91aa
to
0495d9a
Compare
const userKeychain = await coin.keychains().create(); | ||
const backupKeychain = await coin.keychains().create(); | ||
const bitgoKeychain = await coin.keychains().create(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const userKeychain = await coin.keychains().create(); | |
const backupKeychain = await coin.keychains().create(); | |
const bitgoKeychain = await coin.keychains().create(); | |
const [ userKeychain, backupKeychain, bitgoKeychain] = await Promise.all([ | |
coin.keychains().create(), | |
coin.keychains().create(), | |
coin.keychains().create() | |
]); |
NIT: we can use promise.all instead of serially creating keychains
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe we are making http requests here anyway though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are synchronous operations, Promise.all won't speed them up.
Addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits
Loop over all utxo coins BG-79423
BG-79423