chore(sdk-coin-bsc): rename bsc to bnb #3701
Conversation
kxl4126
force-pushed
the
EA-709-bnb-renaming
branch
from
8b68cbf
to
7ec3389
Compare
|
We want to be wary of a possible HSM change as well. |
|
Has there been consideration in not touching this module until it is fully deprecated and spinning up a new bnb module? |
There was a problem hiding this comment.
Think we can keep the chain name as Binance smart chain itself, Not BNB smart chain, Other than that things looks good, Adding do not merge for this untill we made associated changes in all other Microservices. Think we have a lot of places to update inorder to have this updated everywhere and also we can consider @mmcshinsky-bitgo suggestion so that this becomes non-breaking
| 'Binance Smart Chain', | ||
| Networks.main.bsc, | ||
| 'bnb', | ||
| 'BNB Smart Chain', |
There was a problem hiding this comment.
Why change Binance to BNB?
There was a problem hiding this comment.
Oh I think BSC is trying to distance itself from Binance exchange so they want to brand BSC (the chain) as BNB Smart Chain. That's what I read at least.
There was a problem hiding this comment.
The Binance Chain, where staking and voting occur (BNB Chain Governance), has changed its identity to BNB Beacon Chain under the rebranded BNB Chain umbrella. The Binance Smart Chain, which supports several blockchains and is compatible with the EVM, is known simply as BNB Smart Chain, still abbreviated as BSC.
| 'Testnet Binance Smart Chain', | ||
| Networks.test.bsc, | ||
| 'tbnb', | ||
| 'Testnet BNB Smart Chain', |
There was a problem hiding this comment.
I think we could keep Binance as is ?
kxl4126
force-pushed
the
EA-709-bnb-renaming
branch
from
8307d3f
to
fe0de21
Compare
I think this is good route to take --- I'll follow up with team. |
Ticket: EA-709
This is a breaking change for services that rely on SDK BSC constants like WP. Will verify corresponding WP changes with alpha release.