refactor(sdk-coin-atom): use abstract-cosmos #4141
Conversation
hitansh-bitgo
force-pushed
the
WIN-1192-atom-refactor
branch
2 times, most recently
from
dccf889
to
f83c550
Compare
hitansh-bitgo
dismissed stale reviews from mullapudipruthvik and OttoAllmendinger
via
c8eab8f
hitansh-bitgo
force-pushed
the
WIN-1192-atom-refactor
branch
2 times, most recently
from
c8eab8f
to
259b04b
Compare
| export { KeyPair } from './keyPair'; | ||
| export { Transaction } from './transaction'; |
There was a problem hiding this comment.
Removal of all these exports completely from here is a breaking change since /src/index.ts exposes these to end users.
There was a problem hiding this comment.
Added some of the exports back from abstract-cosmos & added a breaking change footer in the commit message for the ones still being removed completely
hitansh-bitgo
force-pushed
the
WIN-1192-atom-refactor
branch
from
259b04b
to
7fce22f
Compare
| export const validDenoms = ['natom', 'uatom', 'matom', 'atom']; | ||
| export const accountAddressRegex = /^(cosmos)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l']{38})$/; | ||
| export const validatorAddressRegex = /^(cosmosvaloper)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l']{38})$/; | ||
| export const contractAddressRegex = /^(cosmos)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l']+)$/; |
There was a problem hiding this comment.
why removing contractAddressRegex ?
There was a problem hiding this comment.
Contract support was only added in abstract-cosmos & other chains but wasn't added for Atom it seems, so this was unused. I've updated the PR with the contract support changes needed for atom as well.
| @@ -1438,7 +1438,7 @@ export enum KeyCurve { | |||
| * This enum contains the base units for the coins that BitGo supports | |||
| */ | |||
| export enum BaseUnit { | |||
| ATOM = 'uATOM', | |||
| ATOM = 'uatom', | |||
There was a problem hiding this comment.
Will this break anything in WP or we use lowercase there ?
There was a problem hiding this comment.
We were using lowercase everywhere except here
hitansh-bitgo
force-pushed
the
WIN-1192-atom-refactor
branch
from
7fce22f
to
5914414
Compare
Ticket: WIN-1192 BREAKING CHANGE: restructured exports - Removed constants overlapping with @bitgo/abstract-cosmos - Removed common Interfaces exported by @bitgo/abstract-cosmos Code dependent on the previously exported Interfaces/Constants needs to be updated to import these from @bitgo/abstract-cosmos instead
hitansh-bitgo
force-pushed
the
WIN-1192-atom-refactor
branch
from
5914414
to
18abbea
Compare
Ticket: WIN-1192