fix(abstract-eth): fix issue related to chain id #4177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianchandania
force-pushed
the
WIN-1446-update-chainid-related-changes
branch
3 times, most recently
from
982f5c2
to
c5d4d18
Compare
gianchandania
force-pushed
the
WIN-1446-update-chainid-related-changes
branch
from
ad0e0ab
to
c3a21c4
Compare
gianchandania
changed the title
sachushaji
approved these changes
Jan 3, 2024
pranavjain97
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts chain id related changes done in this PR for opeth as the chain id related changes didn't work as expected. It also adds some testcases for arbeth, opeth and zketh.
We are keeping arbeth operation hash prefix as chain id and reverting back the operation hash prefix for opeth for time being for testing other flows
WIN-1446
TICKET: WIN-1446