Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(abstract-eth): move address init tests to abstract-eth #4265

Closed
wants to merge 2 commits into from
Closed

test(abstract-eth): move address init tests to abstract-eth #4265

wants to merge 2 commits into from

Conversation

gianchandania
Copy link
Contributor

WIN-1926

This PR moves address init tests to abstract-eth
TICKET: WIN-1926

@gianchandania
test(abstract-eth): move address init tests to abstract-eth
0eb2ac5 
WIN-1926

This PR moves address init tests to abstract-eth
TICKET: WIN-1926
@gianchandania gianchandania marked this pull request as ready for review February 7, 2024 11:14
@gianchandania gianchandania requested review from a team as code owners February 7, 2024 11:14
@gianchandania gianchandania marked this pull request as draft February 7, 2024 12:18
@gianchandania
fix(sdk-core): allow v4 forwarders
036de29 
WIN-1926

This PR allows creation of v4 forwarders
TICKET: WIN-1926
OttoAllmendinger
OttoAllmendinger reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@OttoAllmendinger OttoAllmendinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatic comment to flush this PR from my review queue. 🚽🚽🚽
Please re-request another review from the respective team(s) when you are ready for reviews.

lcovar
lcovar reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@lcovar lcovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flushing

mmcshinsky-bitgo
mmcshinsky-bitgo reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@mmcshinsky-bitgo mmcshinsky-bitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bitgo module doesn't have a fix(sdk-core). Can we move it out of this commit to not trigger an unneeded version bump?

zahin-mohammad
zahin-mohammad reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@zahin-mohammad zahin-mohammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flush

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Apr 16, 2024
@github-actions GitHub Actions
Copy link

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcshinsky-bitgo mmcshinsky-bitgo mmcshinsky-bitgo left review comments

@lcovar lcovar lcovar left review comments

@zahin-mohammad zahin-mohammad zahin-mohammad left review comments

@OttoAllmendinger OttoAllmendinger OttoAllmendinger left review comments

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gianchandania @OttoAllmendinger @zahin-mohammad @lcovar @mmcshinsky-bitgo