Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Win 2117 fix recover token method #4302

Merged
merged 5 commits into from
Feb 23, 2024
Merged

Win 2117 fix recover token method #4302

merged 5 commits into from
Feb 23, 2024

Conversation

gianchandania
Copy link
Contributor

@gianchandania gianchandania commented Feb 22, 2024 •
edited
Loading

This PR adds recover token method for ethlike coins and tests for the same. It also refactors a recovery related method in sdk-coin-opeth, sdk-coin-polygon, sdk-coin-zketh and sdk-coin-arbeth modules

@socket-security Socket Security
Copy link

socket-security bot commented Feb 22, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] Transitive: environment +3 2.42 MB nicolo-ribaudo
npm/@babel/[email protected] None 0 31.6 kB nicolo-ribaudo
npm/@babel/[email protected] None +1 35.7 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 3.48 kB nicolo-ribaudo
npm/@babel/[email protected] environment +2 2.42 MB nicolo-ribaudo
npm/@colors/[email protected] environment 0 39.5 kB dabh
npm/@ethersproject/[email protected] Transitive: network +22 1.46 MB ricmoo
npm/@ethersproject/[email protected] Transitive: network +23 1.54 MB ricmoo
npm/@ethersproject/[email protected] None +7 514 kB ricmoo
npm/@ethersproject/[email protected] None +2 162 kB ricmoo
npm/@ethersproject/[email protected] None +3 392 kB ricmoo
npm/@ethersproject/[email protected] None +1 150 kB ricmoo
npm/@ethersproject/[email protected] None +4 411 kB ricmoo
npm/@ethersproject/[email protected] Transitive: network +24 1.8 MB ricmoo
npm/@ethersproject/[email protected] None +3 209 kB ricmoo
npm/@ethersproject/[email protected] None 0 69.5 kB ricmoo
npm/@ethersproject/[email protected] None +1 117 kB ricmoo
npm/@ethersproject/[email protected] None +1 100 kB ricmoo
npm/@ethersproject/[email protected] None +2 180 kB ricmoo
npm/@ethersproject/[email protected] None +10 719 kB ricmoo
npm/@ethersproject/[email protected] None +5 530 kB ricmoo
npm/@ethersproject/[email protected] None +17 1.09 MB ricmoo
npm/@ethersproject/[email protected] network +8 700 kB ricmoo
npm/@jridgewell/[email protected] None +2 141 kB jridgewell
npm/@noble/[email protected] None 0 737 kB paulmillr
npm/@nodelib/[email protected] filesystem 0 11.8 kB mrmlnc
npm/@protobufjs/[email protected] None 0 9.05 kB dcode
npm/@sinonjs/[email protected] None +1 80.8 kB mrgnrdrck
npm/@types/[email protected] None 0 24 kB types
npm/@types/[email protected] None 0 6.12 kB types
npm/[email protected] None 0 4.78 kB isaacs
npm/[email protected] None +3 268 kB dougwilson
npm/[email protected] None +1 1.23 MB rreverser
npm/[email protected] None 0 42.8 kB marijn
npm/[email protected] None 0 1.21 MB marijn
npm/[email protected] Transitive: environment +2 83.8 kB tootallnate
npm/[email protected] eval +5 1.48 MB esp
npm/[email protected] None +1 135 kB sindresorhus
npm/[email protected] None 0 17 kB sindresorhus
npm/[email protected] None +2 109 kB phated
npm/[email protected] None 0 8.05 kB iarna
npm/[email protected] None 0 8.42 kB substack
npm/[email protected] environment, filesystem +1 151 kB vitaly
npm/[email protected] None 0 4.42 kB blakeembrey
npm/[email protected] None 0 3.17 kB sindresorhus
npm/[email protected] None 0 33.9 kB kriskowal
npm/[email protected] None +2 93.7 kB indutny
npm/[email protected] environment 0 11.4 kB pfmooney
npm/[email protected] None 0 821 kB hargasinski
npm/[email protected] None +1 41.4 kB junderw
npm/[email protected] None 0 9.62 kB feross
npm/[email protected] Transitive: environment +6 317 kB matteo.collina
npm/[email protected] environment, eval, unsafe 0 632 kB esailija
npm/[email protected] None 0 99 kB fanatid
npm/[email protected] None +3 98.1 kB doowb
npm/[email protected] None 0 3.52 kB indutny
npm/[email protected] Transitive: environment +12 284 kB cwmma
npm/[email protected] None +3 141 kB cwmma
npm/[email protected] Transitive: environment +12 263 kB dcousens
npm/[email protected] None 0 4.83 kB dcousens
npm/[email protected] None 0 11.7 kB sindresorhus
npm/[email protected] environment, filesystem +13 358 kB paulmillr
npm/[email protected] None +1 40.1 kB cwmma
npm/[email protected] None 0 4.37 kB sindresorhus
npm/[email protected] None 0 17 kB jorgebucaran
npm/[email protected] None +1 19.5 kB alexindigo
npm/[email protected] Transitive: environment +5 185 kB mafintosh
npm/[email protected] None 0 10.5 kB dougwilson
npm/[email protected] filesystem +5 173 kB oss-bot
npm/[email protected] Transitive: environment +8 1.65 MB oss-bot
npm/[email protected] None 0 23.1 kB dougwilson
npm/[email protected] Transitive: environment +9 245 kB cwmma
npm/[email protected] Transitive: environment +10 250 kB cwmma
npm/[email protected] environment Transitive: filesystem, shell +6 81.2 kB kentcdodds
npm/[email protected] environment, filesystem, shell +5 52.1 kB satazor
npm/[email protected] Transitive: environment +36 955 kB cwmma
npm/[email protected] Transitive: eval +7 665 kB medikoo
npm/[email protected] environment +1 49.2 kB qix
npm/[email protected] None 0 2.94 kB sindresorhus
npm/[email protected] None 0 8.11 kB thlorenz
npm/[email protected] environment, eval 0 27.1 kB dougwilson
npm/[email protected] None 0 4.01 kB gr2m
npm/[email protected] None 0 369 kB kpdecker
npm/[email protected] None +3 142 kB feedic
npm/[email protected] None 0 11.4 kB feedic
npm/[email protected] None +1 55.9 kB feedic
npm/[email protected] network +4 199 kB feedic
npm/[email protected] environment, filesystem 0 24.9 kB motdotla
npm/[email protected] eval, filesystem 0 142 kB mde
npm/[email protected] None +5 195 kB indutny
npm/[email protected] None 0 6.23 kB mafintosh
npm/[email protected] None 0 57.7 kB feedic
npm/[email protected] eval +7 665 kB medikoo
npm/[email protected] Transitive: eval +7 665 kB medikoo
npm/[email protected] filesystem Transitive: environment, unsafe +2 11.3 MB bpscott
npm/[email protected] None +2 128 kB eslintbot
npm/[email protected] None 0 314 kB ariya
npm/[email protected] None 0 36.3 kB michaelficarra
npm/[email protected] None 0 38 kB lpinca
npm/[email protected] None 0 82.8 kB goto-bus-stop
npm/[email protected] Transitive: environment +6 196 kB dcousens
npm/[email protected] environment, shell Transitive: filesystem +15 208 kB sindresorhus
npm/[email protected] None 0 23.5 kB ljharb
npm/[email protected] None 0 22.8 kB dap
npm/[email protected] None 0 13 kB esp
npm/[email protected] None 0 9.44 kB hiddentao
npm/[email protected] filesystem +8 60 kB sindresorhus
npm/[email protected] Transitive: filesystem +5 43.7 kB sindresorhus
npm/[email protected] filesystem, network +5 314 kB niftylettuce
npm/[email protected] filesystem Transitive: environment +4 189 kB ryanzim
npm/[email protected] None 0 16.7 kB ljharb
npm/[email protected] None 0 4.72 kB stefanpenner
npm/[email protected] shell Transitive: environment +7 1.61 MB oss-bot
npm/[email protected] None +2 32 kB phated
npm/[email protected] None 0 39.8 kB sindresorhus
npm/[email protected] None +2 54.7 kB ljharb
npm/[email protected] filesystem +6 99.4 kB sindresorhus
npm/[email protected] environment, filesystem 0 32.5 kB isaacs
npm/[email protected] None 0 12.8 kB ljharb
npm/[email protected] None 0 20.6 kB ljharb
npm/[email protected] None +1 43.2 kB indutny
npm/[email protected] None 0 124 kB mathias
npm/[email protected] network +5 305 kB feedic
npm/[email protected] None 0 35.9 kB kornel
npm/[email protected] Transitive: environment, eval +4 66.8 kB dougwilson
npm/[email protected] network Transitive: environment +4 117 kB tootallnate
npm/[email protected] network 0 2.79 kB feross
npm/[email protected] network Transitive: environment +3 110 kB tootallnate
npm/[email protected] environment, filesystem, shell 0 6.44 kB typicode
npm/[email protected] None +1 378 kB ashtuchkin
npm/[email protected] None 0 51.2 kB kael
npm/[email protected] Transitive: filesystem, unsafe +3 19.8 kB sindresorhus
npm/[email protected] None 0 9.3 kB isaacs
npm/[email protected] None +4 92.6 kB ljharb
npm/[email protected] Transitive: environment +2 28.5 kB zertosh
npm/[email protected] None 0 42.1 kB whitequark
npm/[email protected] None +2 60.3 kB ljharb
npm/[email protected] None 0 11.9 kB ljharb
npm/[email protected] None 0 28.9 kB ljharb
npm/[email protected] None +2 52.3 kB ljharb
npm/[email protected] filesystem 0 3.01 kB sindresorhus
npm/[email protected] None +1 19.8 kB phated
npm/[email protected] None 0 2.62 kB sindresorhus
npm/[email protected] None +2 61.6 kB ljharb
npm/[email protected] None +2 50.6 kB ljharb
npm/[email protected] None +1 42.6 kB ljharb
npm/[email protected] None 0 4.41 kB hughsk
npm/[email protected] None 0 6.93 kB doowb
npm/[email protected] None 0 29.3 kB oss-bot
npm/[email protected] None 0 52.9 kB emn178
npm/[email protected] None 0 15.1 kB lydell
npm/[email protected] None 0 10.4 kB isaacs
npm/[email protected] None 0 12.7 kB isaacs
npm/[email protected] None 0 235 kB jordanbtucker
npm/[email protected] None 0 36.8 kB creationix
npm/[email protected] None +1 36.8 kB
npm/[email protected] None 0 22.8 kB doowb
npm/[email protected] None 0 1.41 MB bnjmnt4n
npm/[email protected] environment +1 20.9 kB zertosh
npm/[email protected] None 0 2.46 kB sindresorhus
npm/[email protected] None +1 30.5 kB isaacs
npm/[email protected] None 0 8.9 kB zensh
npm/[email protected] network 0 5.29 kB dougwilson
npm/[email protected] None +5 244 kB jonschlinkert
npm/[email protected] None 0 206 kB dougwilson
npm/[email protected] None +1 224 kB dougwilson
npm/[email protected] None 0 3.58 kB sindresorhus
npm/[email protected] None 0 1.55 kB cwmma
npm/[email protected] None +1 62.8 kB isaacs
npm/[email protected] environment, filesystem 0 19.1 kB isaacs
npm/[email protected] None +7 1.01 MB hugomrdias
npm/[email protected] None 0 6.51 kB isaacs
npm/[email protected] None 0 27.4 kB dougwilson
npm/[email protected] None 0 298 kB suguru03
npm/[email protected] None 0 7.65 kB medikoo
npm/[email protected] None 0 420 kB nicknaso
npm/[email protected] None 0 9.22 kB jonschlinkert
npm/[email protected] environment +1 12.7 kB sindresorhus
npm/[email protected] None 0 5.49 kB sindresorhus
npm/[email protected] None +1 10.6 kB sindresorhus
npm/[email protected] environment, filesystem, shell +3 57.5 kB sindresorhus
npm/[email protected] Transitive: environment +18 411 kB cwmma
npm/[email protected] None 0 10.3 kB dougwilson
npm/[email protected] None 0 4.55 kB sindresorhus
npm/[email protected] Transitive: environment +11 264 kB cwmma
npm/[email protected] None 0 90 kB mrmlnc
npm/[email protected] Transitive: filesystem +6 48.5 kB sindresorhus
npm/[email protected] environment, filesystem, unsafe 0 11.2 MB prettier-bot
npm/[email protected] None 0 15.3 kB cwmma
npm/[email protected] None 0 15.5 kB turbopope
npm/[email protected] None 0 9.29 kB ionicabizau
npm/[email protected] environment 0 29.5 kB rob-w
npm/[email protected] None 0 32.9 kB google-wombot
npm/[email protected] None 0 123 kB kriskowal
npm/[email protected] None +2 275 kB ljharb
npm/[email protected] None +1 38.5 kB cwmma
npm/[email protected] None 0 8.46 kB dougwilson
npm/[email protected] environment +2 145 kB matteo.collina
npm/[email protected] filesystem +1 110 kB paulmillr
npm/[email protected] None 0 27.8 kB benjamn
npm/[email protected] filesystem, unsafe 0 5.82 kB sindresorhus
npm/[email protected] Transitive: environment, filesystem +2 19.5 kB sindresorhus
npm/[email protected] filesystem +3 115 kB isaacs
npm/[email protected] Transitive: environment +5 193 kB dcousens
npm/[email protected] None +1 162 kB ralxz
npm/[email protected] None 0 6.6 kB sboudrias
npm/[email protected] None +1 4.56 MB blesh
npm/[email protected] None 0 32.1 kB feross
npm/[email protected] None 0 42.3 kB chalker
npm/[email protected] None 0 226 kB ricmoo
npm/[email protected] None 0 8.56 kB domenic
npm/[email protected] None +1 63.2 kB dcousens
npm/[email protected] None 0 15.9 kB btd
npm/[email protected] eval +5 495 kB btd
npm/[email protected] None 0 9.96 kB isaacs
npm/[email protected] None 0 138 kB joshglazebrook
npm/[email protected] None 0 148 kB 7rulnik
npm/[email protected] None 0 805 kB tromey
npm/[email protected] None 0 11.8 kB kemitchell
npm/[email protected] Transitive: environment +3 156 kB goto-bus-stop
npm/[email protected] Transitive: environment, network +5 182 kB jhiesey
npm/[email protected] None 0 15.3 kB matteo.collina
npm/[email protected] None +4 68 kB sindresorhus
npm/[email protected] None +1 9.64 kB sindresorhus
npm/[email protected] None +1 19.1 kB silentcicero
npm/[email protected] None 0 6.96 kB sindresorhus
npm/[email protected] None 0 46.9 kB sokra
npm/[email protected] filesystem +4 168 kB raszi
npm/[email protected] network +2 581 kB jstash
npm/[email protected] None 0 60 kB typescript-bot
npm/[email protected] None 0 174 kB dchest
npm/[email protected] None +1 57.9 kB gkz
npm/[email protected] None 0 42.1 kB chaijs
npm/[email protected] None 0 26 kB substack
npm/[email protected] environment, eval, filesystem 0 1.28 MB alexlamsl
npm/[email protected] None 0 4.31 kB dougwilson
npm/[email protected] None 0 11.2 kB mathias
npm/[email protected] None 0 5.48 kB tootallnate
npm/[email protected] environment Transitive: eval +4 126 kB goto-bus-stop
npm/[email protected] None 0 116 kB ctavan
npm/[email protected] None +2 51.9 kB kemitchell
npm/[email protected] None 0 8.75 kB dougwilson
npm/[email protected] None +2 29.2 kB timoxley
npm/[email protected] environment Transitive: filesystem +1 20.9 kB isaacs
npm/[email protected] filesystem +2 34.1 kB gar
npm/[email protected] None +7 115 kB naugtur
npm/[email protected] None 0 6.46 kB raynos
npm/[email protected] None 0 14.8 kB isaacs
npm/[email protected] environment 0 448 kB eemeli
npm/[email protected] environment, filesystem 0 124 kB oss-bot

🚮 Removed packages: npm/@bitgo/[email protected], npm/@types/[email protected]

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented Feb 22, 2024 •
edited
Loading

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package Note
Protestware/Troll package npm/[email protected]
  • Note: This package prints a protestware console message on install regarding Ukraine for users with Russian language locale
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: node -e "try{require('./_postinstall')}catch(e){}" || exit 0

View full report↗︎

Next steps

What is protestware?

This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function.

Consider that consuming this package my come along with functionality unrelated to its primary purpose.

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@gianchandania
fix(abstract-eth): fix recover token method for ethlike
0c074a9 
WIN-2117

This commit adds recover token method for ethlike coins
TICKET: WIN-2117
@gianchandania
test(sdk-coin-arbeth): add recover token tests
547df19 
WIN-2117

This commit adds tests for recovering token using unsigned sweep and non
bitgo recovery
TICKET: WIN-2117
@gianchandania
refactor(sdk-coin-opeth): refactor recovery related method
0f630bc 
WIN-2117

This commit refactors the token recovery related method
TICKET: WIN-2117
@gianchandania
refactor(sdk-coin-polygon): refactor recover token related methods
806c874 
WIN-2117

This commit refactors token recovery related methods for polygon
TICKET: WIN-2117
@gianchandania
refactor(sdk-coin-zketh): refactor recover token related methods
412e67b 
WIN-2117
TICKET: WIN-2117
@gianchandania gianchandania marked this pull request as ready for review February 22, 2024 16:10
@gianchandania gianchandania requested review from a team as code owners February 22, 2024 16:10
@gianchandania gianchandania merged commit f97e109 into master Feb 23, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pengyuc-bitgo pengyuc-bitgo pengyuc-bitgo approved these changes

@sachushaji sachushaji sachushaji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gianchandania @sachushaji @pengyuc-bitgo