New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk-lib-mpc): use crypto module for safe prime #4380

Merged

zahin-mohammad merged 2 commits into master from WP-967/remove-openssl

Apr 1, 2024

Contributor

zahin-mohammad commented Mar 28, 2024 •

edited

Loading

feat(sdk-lib-mpc): use crypto module for safe prime

deletes openssl wasm + code
uses crypto module to generate safe prime

BREAKING-CHANGE: OpenSSL is no longer exported
TICKET: WP-967

feat(sdk-core): Deprecate openssl class

Removes use of the openssl class
No longer exports the openssl class
See sdk-lib-mpc on how to generate safe primes

BREAKING-CHANGE: OpenSSL is no longer exported from sdk-core
TICKET: WP-967

zahin-mohammad force-pushed the WP-967/remove-openssl branch 2 times, most recently from a794264 to cb8ad08 Compare

March 28, 2024 19:04

zahin-mohammad added 2 commits

March 28, 2024 15:11


          feat(sdk-lib-mpc): use crypto module for safe prime

3113e6a

- deletes openssl wasm + code
- uses crypto module to generate safe prime

BREAKING-CHANGE: OpenSSL is no longer exported
TICKET: WP-967


          feat(sdk-core): deprecate openssl class

9fa06ba

- Removes use of the openssl class
- No longer exports the openssl class
- See sdk-lib-mpc on how to generate safe primes

BREAKING-CHANGE: OpenSSL is no longer exported from sdk-core
TICKET: WP-967

zahin-mohammad force-pushed the WP-967/remove-openssl branch from cb8ad08 to 9fa06ba Compare

March 28, 2024 19:11

socket-security bot commented Mar 28, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@bitgo/[email protected]	None	`0`	2.27 MB	zahin-mohammad
npm/@types/[email protected]	None	`0`	12.3 kB	types

🚮 Removed packages: npm/@babel/[email protected], npm/@csstools/[email protected], npm/@csstools/[email protected], npm/@csstools/[email protected], npm/@csstools/[email protected], npm/@csstools/[email protected], npm/@csstools/[email protected], npm/@csstools/[email protected], npm/@csstools/[email protected], npm/@csstools/[email protected], npm/@csstools/[email protected], npm/@csstools/[email protected], npm/@csstools/[email protected], npm/@csstools/[email protected], npm/@csstools/[email protected], npm/@csstools/[email protected], npm/@ethereumjs/[email protected], npm/@ethereumjs/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@jridgewell/[email protected], npm/@noble/[email protected], npm/@nodelib/[email protected], npm/@protobufjs/[email protected], npm/@scure/[email protected], npm/@sinonjs/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

zahin-mohammad marked this pull request as ready for review

March 28, 2024 19:38

zahin-mohammad requested review from a team as code owners

March 28, 2024 19:38

alebusse approved these changes

View reviewed changes

zahin-mohammad merged commit 614d3ef into master

8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet