feat: modify accept share method #4419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravneet-bitgo
force-pushed
the
ravneet/PX-3296-modify-accept-share
branch
16 times, most recently
from
502f432
to
c214c4e
Compare
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
ravneet-bitgo
force-pushed
the
ravneet/PX-3296-modify-accept-share
branch
from
c214c4e
to
a87b65e
Compare
ravneet-bitgo
commented
Apr 12, 2024
ravneet-bitgo
force-pushed
the
ravneet/PX-3296-modify-accept-share
branch
from
a87b65e
to
4a6f2b4
Compare
mandalarnav
reviewed
Apr 15, 2024
manav-c
reviewed
Apr 16, 2024
manav-c
reviewed
Apr 16, 2024
ravneet-bitgo
force-pushed
the
ravneet/PX-3296-modify-accept-share
branch
from
f7c1cea
to
b284738
Compare
ravneet-bitgo
force-pushed
the
ravneet/PX-3296-modify-accept-share
branch
2 times, most recently
from
7968a5b
to
37966ec
Compare
|
please add tests |
zahin-mohammad
requested changes
Apr 17, 2024
ravneet-bitgo
force-pushed
the
ravneet/PX-3296-modify-accept-share
branch
5 times, most recently
from
7e12ac2
to
47fc503
Compare
ravneet-bitgo
force-pushed
the
ravneet/PX-3296-modify-accept-share
branch
from
47fc503
to
0b6dbbc
Compare
Added |
ravneet-bitgo
force-pushed
the
ravneet/PX-3296-modify-accept-share
branch
2 times, most recently
from
30254c8
to
acede33
Compare
ravneet-bitgo
requested review from
zahin-mohammad,
mmcshinsky-bitgo,
manav-c,
mandalarnav and
shivagupta94
ravneet-bitgo
force-pushed
the
ravneet/PX-3296-modify-accept-share
branch
from
acede33
to
38784bd
Compare
zahin-mohammad
requested changes
Apr 18, 2024
shivagupta94
force-pushed
the
ravneet/PX-3296-modify-accept-share
branch
from
b120561
to
9a25a54
Compare
Ticket: PX-3296 We are modifying the accept share method for go account wallet invitations
shivagupta94
force-pushed
the
ravneet/PX-3296-modify-accept-share
branch
from
79e3459
to
0438bc9
Compare
zahin-mohammad
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: PX-3296
Description
We are modifying the accept share method for go account wallet invitations. If the
keychainOverrideRequiredkey is present in the walletShare, we need to create a new keychain and pass the same to theupdateSharemethod so we can override the existing key. After successful completion of the same, we need toreshareWalletto all the existing spenders.TDD: link