Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(root): add DX prefix to commitlint #4441

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

ekorenblum-simtlix
Copy link
Contributor

@ekorenblum-simtlix ekorenblum-simtlix commented Apr 16, 2024

Description

The DX prefix is used by the DevEx team, and commits referencing DevEx tickets would fail if this isn't added

Issue Number

DX-315

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • CI change

How Has This Been Tested?

A commit was pushed with the new prefix, and all tests passed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My code compiles correctly for both Node and Browser environments
  • I have commented my code, particularly in hard-to-understand areas
  • My commits follow Conventional Commits and I have properly described any BREAKING CHANGES
  • The ticket or github issue was included in the commit message as a reference
  • I have made corresponding changes to the documentation and on any new/updated functions and/or methods - jsdoc
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

The DX prefix is used by the DevEx team, and commits referencing DevEx tickets would fail if this
isn't added

Refs DX-315

TICKET: DX-315
@ekorenblum-simtlix ekorenblum-simtlix marked this pull request as ready for review April 16, 2024 14:25
@ekorenblum-simtlix ekorenblum-simtlix requested review from a team as code owners April 16, 2024 14:25
@alebusse alebusse merged commit 522d2df into master Apr 16, 2024
9 checks passed
@ericcrosson-bitgo ericcrosson-bitgo deleted the DX-315-add-DX-prefix-in-commitlint branch April 16, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants