feat(sdk-lib-mpc): add utility to verify dkls signatures #4450
Conversation
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
islamaminBitGo
force-pushed
the
support-signature-verify-util
branch
from
86b1c84
to
9334677
Compare
| } | ||
| return `${recId}${delimeter}${Buffer.from(dklsSignature.R).toString('hex')}${delimeter}${Buffer.from( | ||
| dklsSignature.S | ||
| ).toString('hex')}${delimeter}${commonKeychain.slice(0, 66)}`; |
There was a problem hiding this comment.
could use truePub in place of commonKeychain.slice(0, 66)
islamaminBitGo
force-pushed
the
support-signature-verify-util
branch
from
9334677
to
5e73818
Compare
| let recId = 0; | ||
| if (truePub === Buffer.from(pub1).toString('hex')) { | ||
| recId = 1; | ||
| } else if (truePub !== Buffer.from(pub0).toString('hex')) { | ||
| throw Error('Invalid Signature'); | ||
| } |
There was a problem hiding this comment.
let recId;
if (truePub === Buffer.from(pub0).toString('hex')) {
recId = 0;
} else if (truePub === Buffer.from(pub1).toString('hex')) {
recId = 1;
} else {
throw ...
}
is more readable IMO, though a little longer.
There was a problem hiding this comment.
agreed, that's what i had first and then i made the wrong decision to go for compact over readable
islamaminBitGo
force-pushed
the
support-signature-verify-util
branch
from
5e73818
to
eb0824d
Compare
Ticket: HSM-341